| Message ID | 20240807003032.10300-1-christopher.s.hall@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | igc: PTM timeout fix | expand |
Hi Christopher, are you planning a followup to this patch series any tinme soon? Thanks, Corinna On Aug 6 17:30, christopher.s.hall@intel.com wrote: > From: Christopher S M Hall <christopher.s.hall@intel.com> > > There have been sporadic reports of PTM timeouts using i225/i226 devices > > These timeouts have been root caused to: > > 1) Manipulating the PTM status register while PTM is enabled and triggered > 2) The hardware retrying too quickly when an inappropriate response is > received from the upstream device > > The issue can be reproduced with the following: > > $ sudo phc2sys -R 1000 -O 0 -i tsn0 -m > > Note: 1000 Hz (-R 1000) is unrealistically large, but provides a way to > quickly reproduce the issue. > > PHC2SYS exits with: > > "ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM transaction > fails > > Christopher S M Hall (5): > igc: Ensure the PTM cycle is reliably triggered > igc: Lengthen the hardware retry time to prevent timeouts > igc: Move ktime snapshot into PTM retry loop > igc: Reduce retry count to a more reasonable number > igc: Add lock preventing multiple simultaneous PTM transactions > > drivers/net/ethernet/intel/igc/igc.h | 1 + > drivers/net/ethernet/intel/igc/igc_defines.h | 3 +- > drivers/net/ethernet/intel/igc/igc_ptp.c | 100 +++++++++++-------- > 3 files changed, 63 insertions(+), 41 deletions(-) > > -- > 2.34.1
From: Christopher S M Hall <christopher.s.hall@intel.com> There have been sporadic reports of PTM timeouts using i225/i226 devices These timeouts have been root caused to: 1) Manipulating the PTM status register while PTM is enabled and triggered 2) The hardware retrying too quickly when an inappropriate response is received from the upstream device The issue can be reproduced with the following: $ sudo phc2sys -R 1000 -O 0 -i tsn0 -m Note: 1000 Hz (-R 1000) is unrealistically large, but provides a way to quickly reproduce the issue. PHC2SYS exits with: "ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM transaction fails Christopher S M Hall (5): igc: Ensure the PTM cycle is reliably triggered igc: Lengthen the hardware retry time to prevent timeouts igc: Move ktime snapshot into PTM retry loop igc: Reduce retry count to a more reasonable number igc: Add lock preventing multiple simultaneous PTM transactions drivers/net/ethernet/intel/igc/igc.h | 1 + drivers/net/ethernet/intel/igc/igc_defines.h | 3 +- drivers/net/ethernet/intel/igc/igc_ptp.c | 100 +++++++++++-------- 3 files changed, 63 insertions(+), 41 deletions(-)