[net-next,v5,00/12] ethtool: rss: driver tweaks and netlink context dumps

Message

Jakub Kicinski Aug. 10, 2024, 5:37 a.m. UTC

This series is a semi-related collection of RSS patches.
Main point is supporting dumping RSS contexts via ethtool netlink.
At present additional RSS contexts can be queried one by one, and
assuming user know the right IDs. This series uses the XArray
added by Ed to provide netlink dump support for ETHTOOL_GET_RSS.

Patch 1 is a trivial selftest debug patch.
Patch 2 coverts mvpp2 for no real reason other than that I had
	a grand plan of converting all drivers at some stage.
Patch 3 removes a now moot check from mlx5 so that all tests
	can pass.
Patch 4 and 5 make a bit used for context support optional,
	for easier grepping of drivers which need converting
	if nothing else.
Patch 6 OTOH adds a new cap bit; some devices don't support
	using a different key per context and currently act
	in surprising ways.
Patch 7 and 8 update the RSS netlink code to use XArray.
Patch 9 and 10 add support for dumping contexts.
Patch 11 and 12 are small adjustments to spec and a new test.


I'm getting distracted with other work, so probably won't have
the time soon to complete next steps, but things which are missing
are (and some of these may be bad ideas):

 - better discovery

   Some sort of API to tell the user who many contexts the device
   can create. Upper bound, devices often share contexts between
   ports etc. so it's hard to tell exactly and upfront number of
   contexts for a netdev. But order of magnitude (4 vs 10s) may
   be enough for container management system to know whether to bother.

 - create/modify/delete via netlink
 
   The only question here is how to handle all the tricky IOCTL
   legacy. "No change" maps trivially to attribute not present.
   "reset" (indir_size = 0) probably needs to be a new NLA_FLAG?

 - better table size handling

   The current API assumes the LUT has fixed size, which isn't
   true for modern devices. We should have better APIs for the
   drivers to resize the tables, and in user facing API -
   the ability to specify pattern and min size rather than
   exact table expected (sort of like ethtool CLI already does).

 - recounted / socket-bound contexts

   Support for contexts which get "cleaned up" when their parent
   netlink socket gets closed. The major catch is that ntuple
   filters (which we don't currently track) depend on the context,
   so we need auto-removal for both.

v5:
 - fix build
v4: https://lore.kernel.org/[e-mail]
 - adjust to the meaning of max context from net
v3: https://lore.kernel.org/[e-mail]
 - quite a few code comments and commit message changes
 - mvpp2: fix interpretation of max_context_id (I'll take care of
   the net -> net-next merge as needed)
 - filter by ifindex in the selftest
v2: https://lore.kernel.org/[e-mail]
 - fix bugs and build in mvpp2
v1: https://lore.kernel.org/[e-mail]

Jakub Kicinski (12):
  selftests: drv-net: rss_ctx: add identifier to traffic comments
  eth: mvpp2: implement new RSS context API
  eth: mlx5: allow disabling queues when RSS contexts exist
  ethtool: make ethtool_ops::cap_rss_ctx_supported optional
  eth: remove .cap_rss_ctx_supported from updated drivers
  ethtool: rss: don't report key if device doesn't support it
  ethtool: rss: move the device op invocation out of rss_prepare_data()
  ethtool: rss: report info about additional contexts from XArray
  ethtool: rss: support dumping RSS contexts
  ethtool: rss: support skipping contexts during dump
  netlink: specs: decode indirection table as u32 array
  selftests: drv-net: rss_ctx: test dumping RSS contexts

 Documentation/netlink/specs/ethtool.yaml      |  14 +-
 Documentation/networking/ethtool-netlink.rst  |  12 +-
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |   2 +-
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |   1 +
 .../net/ethernet/marvell/mvpp2/mvpp2_cls.c    |  18 +-
 .../net/ethernet/marvell/mvpp2/mvpp2_cls.h    |   2 +-
 .../net/ethernet/marvell/mvpp2/mvpp2_main.c   | 103 +++++---
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |  13 +-
 drivers/net/ethernet/sfc/ef100_ethtool.c      |   2 +-
 drivers/net/ethernet/sfc/ethtool.c            |   2 +-
 include/linux/ethtool.h                       |   7 +-
 include/uapi/linux/ethtool_netlink.h          |   1 +
 net/ethtool/ioctl.c                           |  31 ++-
 net/ethtool/netlink.c                         |   2 +
 net/ethtool/netlink.h                         |   4 +-
 net/ethtool/rss.c                             | 233 ++++++++++++++++--
 .../selftests/drivers/net/hw/rss_ctx.py       |  80 +++++-
 tools/testing/selftests/net/lib/py/ksft.py    |   6 +
 18 files changed, 442 insertions(+), 91 deletions(-)

Comments

[e-mail] Aug. 12, 2024, 1:20 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <[e-mail]>:

On Fri,  9 Aug 2024 22:37:16 -0700 you wrote:
> This series is a semi-related collection of RSS patches.
> Main point is supporting dumping RSS contexts via ethtool netlink.
> At present additional RSS contexts can be queried one by one, and
> assuming user know the right IDs. This series uses the XArray
> added by Ed to provide netlink dump support for ETHTOOL_GET_RSS.
> 
> Patch 1 is a trivial selftest debug patch.
> Patch 2 coverts mvpp2 for no real reason other than that I had
> 	a grand plan of converting all drivers at some stage.
> Patch 3 removes a now moot check from mlx5 so that all tests
> 	can pass.
> Patch 4 and 5 make a bit used for context support optional,
> 	for easier grepping of drivers which need converting
> 	if nothing else.
> Patch 6 OTOH adds a new cap bit; some devices don't support
> 	using a different key per context and currently act
> 	in surprising ways.
> Patch 7 and 8 update the RSS netlink code to use XArray.
> Patch 9 and 10 add support for dumping contexts.
> Patch 11 and 12 are small adjustments to spec and a new test.
> 
> [...]

Here is the summary with links:
  - [net-next,v5,01/12] selftests: drv-net: rss_ctx: add identifier to traffic comments
    https://git.kernel.org/netdev/net-next/c/10fbe8c082fd
  - [net-next,v5,02/12] eth: mvpp2: implement new RSS context API
    https://git.kernel.org/netdev/net-next/c/f203fd85e666
  - [net-next,v5,03/12] eth: mlx5: allow disabling queues when RSS contexts exist
    https://git.kernel.org/netdev/net-next/c/a7f6f56f604a
  - [net-next,v5,04/12] ethtool: make ethtool_ops::cap_rss_ctx_supported optional
    https://git.kernel.org/netdev/net-next/c/ce056504e2e5
  - [net-next,v5,05/12] eth: remove .cap_rss_ctx_supported from updated drivers
    https://git.kernel.org/netdev/net-next/c/fb770fe7584f
  - [net-next,v5,06/12] ethtool: rss: don't report key if device doesn't support it
    https://git.kernel.org/netdev/net-next/c/ec6e57beaf8b
  - [net-next,v5,07/12] ethtool: rss: move the device op invocation out of rss_prepare_data()
    https://git.kernel.org/netdev/net-next/c/a7ddfd5d5703
  - [net-next,v5,08/12] ethtool: rss: report info about additional contexts from XArray
    https://git.kernel.org/netdev/net-next/c/bb87f2c7968e
  - [net-next,v5,09/12] ethtool: rss: support dumping RSS contexts
    https://git.kernel.org/netdev/net-next/c/f6122900f4e2
  - [net-next,v5,10/12] ethtool: rss: support skipping contexts during dump
    https://git.kernel.org/netdev/net-next/c/3d50c66c0609
  - [net-next,v5,11/12] netlink: specs: decode indirection table as u32 array
    https://git.kernel.org/netdev/net-next/c/8ad3be135212
  - [net-next,v5,12/12] selftests: drv-net: rss_ctx: test dumping RSS contexts
    https://git.kernel.org/netdev/net-next/c/c1ad8ef804e4

You are awesome, thank you!