| Message ID | 20240813-bnxt-str-v2-0-872050a157e7@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | bnxt_en: address string truncation | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 13 Aug 2024 15:32:54 +0100 you wrote: > Hi, > > This series addresses several string truncation issues that are flagged > by gcc-14. I do not have any reason to believe these are bugs, so I am > targeting this at net-next and have not provided Fixes tags. > > > [...] Here is the summary with links: - [net-next,v2,1/2] bnxt_en: Extend maximum length of version string by 1 byte https://git.kernel.org/netdev/net-next/c/ffff7ee843c3 - [net-next,v2,2/2] bnxt_en: avoid truncation of per rx run debugfs filename https://git.kernel.org/netdev/net-next/c/1418e9ab3e2e You are awesome, thank you!
Hi, This series addresses several string truncation issues that are flagged by gcc-14. I do not have any reason to believe these are bugs, so I am targeting this at net-next and have not provided Fixes tags. --- Changes in v2: - Added patch: + bnxt_en: Extend maximum length of version string by 1 byte - Dropped the following patches. - bnxt_en: check for irq name truncation - bnxt_en: check for fw_ver_str truncation + The approach I had taken was to return error on truncation, but the feedback I received was that it would be better to replace the last three bytes with "..." or some other similar scheme. While simple enough to implement, it does add some complexity, and I have so far been unable to convince myself that it is warranted. So I have decided to drop these patches for now. - Link to v1: https://lore.kernel.org/r/20240705-bnxt-str-v1-0-bafc769ed89e@kernel.org --- Simon Horman (2): bnxt_en: Extend maximum length of version string by 1 byte bnxt_en: avoid truncation of per rx run debugfs filename drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c | 4 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) base-commit: dd1bf9f9df156b43e5122f90d97ac3f59a1a5621