[0/3] Correct recent GCC incompatible changes.

Message

Cupertino Miranda Aug. 19, 2024, 3:11 p.m. UTC

Hi everyone,

Apologies for the previous patches which did not include a cover letter.
My wish was to send 3 indepepdent patches but after the initial mistake lets keep
this as a series although they are all independent from themselves.

The changes in this patch series is related to recovering GCC support to
build the selftests.
A few tests and a makefile change have broken the support for GCC in the
last few months.

Looking forward to your comments.

Best regards,
Cupertino

Cupertino Miranda (3):
  selftests/bpf: Disable strict aliasing for verifier_nocsr.c
  selftest/bpf: _GNU_SOURCE redefined in g++
  selftest/bpf: Adapt inline asm operand constraint for GCC support

 tools/testing/selftests/bpf/Makefile                          | 3 ++-
 .../testing/selftests/bpf/progs/tailcall_bpf2bpf_hierarchy2.c | 4 ++--
 .../testing/selftests/bpf/progs/tailcall_bpf2bpf_hierarchy3.c | 4 ++--
 3 files changed, 6 insertions(+), 5 deletions(-)

Comments

[e-mail] Aug. 19, 2024, 10:50 p.m. UTC | #1

Hello:

This series was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <[e-mail]>:

On Mon, 19 Aug 2024 16:11:26 +0100 you wrote:
> Hi everyone,
> 
> Apologies for the previous patches which did not include a cover letter.
> My wish was to send 3 indepepdent patches but after the initial mistake lets keep
> this as a series although they are all independent from themselves.
> 
> The changes in this patch series is related to recovering GCC support to
> build the selftests.
> A few tests and a makefile change have broken the support for GCC in the
> last few months.
> 
> [...]

Here is the summary with links:
  - [1/3] selftests/bpf: Disable strict aliasing for verifier_nocsr.c
    https://git.kernel.org/bpf/bpf-next/c/2aa93695081d
  - [2/3] selftest/bpf: _GNU_SOURCE redefined in g++
    (no matching commit)
  - [3/3] selftest/bpf: Adapt inline asm operand constraint for GCC support
    https://git.kernel.org/bpf/bpf-next/c/d9075ac631ce

You are awesome, thank you!

Yonghong Song Aug. 20, 2024, 7:42 p.m. UTC | #2

On 8/19/24 8:11 AM, Cupertino Miranda wrote:
> Hi everyone,
>
> Apologies for the previous patches which did not include a cover letter.
> My wish was to send 3 indepepdent patches but after the initial mistake lets keep
> this as a series although they are all independent from themselves.
>
> The changes in this patch series is related to recovering GCC support to
> build the selftests.
> A few tests and a makefile change have broken the support for GCC in the
> last few months.

Cupertino, it would be great if we can speed up to add CI test with gcc-bpf, even
just for compilation only.

Cupertino Miranda Aug. 22, 2024, 5:02 p.m. UTC | #3

Hi Yonghong,

Working on it. I am almost done!

Cupertino

On 20-08-2024 20:42, Yonghong Song wrote:
> 
> On 8/19/24 8:11 AM, Cupertino Miranda wrote:
>> Hi everyone,
>>
>> Apologies for the previous patches which did not include a cover letter.
>> My wish was to send 3 indepepdent patches but after the initial 
>> mistake lets keep
>> this as a series although they are all independent from themselves.
>>
>> The changes in this patch series is related to recovering GCC support to
>> build the selftests.
>> A few tests and a makefile change have broken the support for GCC in the
>> last few months.
> 
> Cupertino, it would be great if we can speed up to add CI test with 
> gcc-bpf, even
> just for compilation only.
>

Yonghong Song Aug. 22, 2024, 5:32 p.m. UTC | #4

On 8/22/24 10:02 AM, Cupertino Miranda wrote:
> Hi Yonghong,
>
> Working on it. I am almost done!

Great. Thanks!

>
> Cupertino
>
> On 20-08-2024 20:42, Yonghong Song wrote:
>>
>> On 8/19/24 8:11 AM, Cupertino Miranda wrote:
>>> Hi everyone,
>>>
>>> Apologies for the previous patches which did not include a cover 
>>> letter.
>>> My wish was to send 3 indepepdent patches but after the initial 
>>> mistake lets keep
>>> this as a series although they are all independent from themselves.
>>>
>>> The changes in this patch series is related to recovering GCC 
>>> support to
>>> build the selftests.
>>> A few tests and a makefile change have broken the support for GCC in 
>>> the
>>> last few months.
>>
>> Cupertino, it would be great if we can speed up to add CI test with 
>> gcc-bpf, even
>> just for compilation only.
>>