[v9,net-next,0/3] Enhance network interface feature testing

Message

Abhinav Jain Aug. 21, 2024, 5:19 p.m. UTC

This small series includes fixes for creation of veth pairs for
networkless kernels & adds tests for turning the different network
interface features on and off in selftests/net/netdevice.sh script.
Tested using vng and compiles for network as well as networkless kernel.

Changes in v9:
Removed veth1 to avoid redundant testing as per feedback in v8.

Changes in v8:
https://lore.kernel.org/all/[e-mail]/

Remove redundant variable initial_state as per feedback in v7.

Changes in v7:
https://lore.kernel.org/all/[e-mail]

Create a third patch in the series to do SKIP -> XFAIL replacement.
Add logic to incorporate XFAIL on setting IP address for veth pair.

Changes in v6:
https://lore.kernel.org/all/[e-mail]

Use XFAIL for ethtool operations that are unsupported instead of SKIP.

Changes in v5:
https://lore.kernel.org/all/[e-mail]

Rectify the syntax for ip add link.
Fix the veth_created condition check.

Changes in v4:
https://lore.kernel.org/all/[e-mail]

Move veth creation/removal to the main shell script.
Tested using vng on a networkless kernel and the script works, sample
output below the changes.

Changes in v3:
https://lore.kernel.org/all/[e-mail]

Add a check for netdev, create veth pair for testing.
Restore feature to its initial state.

Changes in v2:
https://lore.kernel.org/all/[e-mail]

Remove tail usage; use read to parse the features from temp file.

v1:
https://lore.kernel.org/all/[e-mail]

```
# selftests: net: netdevice.sh
# No valid network device found, creating veth pair
# PASS: veth0: set interface up
# PASS: veth0: set MAC address
# XFAIL: veth0: set IP address unsupported for veth*
# PASS: veth0: ethtool list features
# PASS: veth0: Turned off feature: rx-checksumming
# PASS: veth0: Turned on feature: rx-checksumming
# PASS: veth0: Restore feature rx-checksumming to initial state on
# Actual changes:
# tx-checksum-ip-generic: off

...

# PASS: veth0: Turned on feature: rx-udp-gro-forwarding
# PASS: veth0: Restore feature rx-udp-gro-forwarding to initial state off
# Cannot get register dump: Operation not supported
# XFAIL: veth0: ethtool dump not supported
# PASS: veth0: ethtool stats
# PASS: veth0: stop interface
```

Abhinav Jain (3):
  selftests: net: Create veth pair for testing in networkless kernel
  selftests: net: Add on/off checks for non-fixed features of interface
  selftests: net: Use XFAIL for operations not supported by the driver

 tools/testing/selftests/net/netdevice.sh | 60 ++++++++++++++++++++++--
 1 file changed, 56 insertions(+), 4 deletions(-)

--
2.34.1

Comments

[e-mail] Aug. 23, 2024, midnight UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Wed, 21 Aug 2024 22:49:00 +0530 you wrote:
> This small series includes fixes for creation of veth pairs for
> networkless kernels & adds tests for turning the different network
> interface features on and off in selftests/net/netdevice.sh script.
> Tested using vng and compiles for network as well as networkless kernel.
> 
> Changes in v9:
> Removed veth1 to avoid redundant testing as per feedback in v8.
> 
> [...]

Here is the summary with links:
  - [v9,net-next,1/3] selftests: net: Create veth pair for testing in networkless kernel
    https://git.kernel.org/netdev/net-next/c/1820b84f3c61
  - [v9,net-next,2/3] selftests: net: Add on/off checks for non-fixed features of interface
    https://git.kernel.org/netdev/net-next/c/6ce7bdbc0d4b
  - [v9,net-next,3/3] selftests: net: Use XFAIL for operations not supported by the driver
    https://git.kernel.org/netdev/net-next/c/8402a158028f

You are awesome, thank you!