[-next,0/2] net/ncsi: Use str_up_down to simplify the code

Message

Hongbo Li Aug. 23, 2024, 6:52 a.m. UTC

In commit a98ae7f045b2, str_up_down() helper is introduced to
return "up" or "down" string literal, so we can use it to
simplify the code and fix the coccinelle warning.

Hongbo Li (2):
  net/ncsi: Use str_up_down to simplify the code
  net/ncsi: Use str_up_down to simplify the code

 net/ncsi/ncsi-aen.c    | 2 +-
 net/ncsi/ncsi-manage.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman Aug. 23, 2024, 4:21 p.m. UTC | #1

On Fri, Aug 23, 2024 at 02:52:57PM +0800, Hongbo Li wrote:
> In commit a98ae7f045b2, str_up_down() helper is introduced to
> return "up" or "down" string literal, so we can use it to
> simplify the code and fix the coccinelle warning.

Hi Hongbo Li,

That commit hasn't propagated into net-next.
I guess these patches need to wait for that to happen.

Hongbo Li Aug. 27, 2024, 2:11 a.m. UTC | #2

On 2024/8/24 0:21, Simon Horman wrote:
> On Fri, Aug 23, 2024 at 02:52:57PM +0800, Hongbo Li wrote:
>> In commit a98ae7f045b2, str_up_down() helper is introduced to
>> return "up" or "down" string literal, so we can use it to
>> simplify the code and fix the coccinelle warning.
> 
> Hi Hongbo Li,
> 
> That commit hasn't propagated into net-next.
> I guess these patches need to wait for that to happen.

Thank you for reminding, I will send the patch into net-next.

Thanks,
Hongbo