mbox series

[net-next,v2,0/2] net/ncsi: Use str_up_down to simplify the code

Message ID 20240827025246.963115-1-lihongbo22@huawei.com (mailing list archive)
Headers show
Series net/ncsi: Use str_up_down to simplify the code | expand

Message

Hongbo Li Aug. 27, 2024, 2:52 a.m. UTC 
In commit a98ae7f045b2, str_up_down() helper is introduced to
return "up" or "down" string literal, so we can use it to
simplify the code and fix the coccinelle warning.

v2:
 - change subject into net-next

v1: https://lore.kernel.org/netdev/20240823162144.GW2164@kernel.org/T/

Hongbo Li (2):
  net/ncsi: Use str_up_down to simplify the code
  net/ncsi: Use str_up_down to simplify the code

 net/ncsi/ncsi-aen.c    | 2 +-
 net/ncsi/ncsi-manage.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman Aug. 27, 2024, 8:52 a.m. UTC | #1 
On Tue, Aug 27, 2024 at 10:52:44AM +0800, Hongbo Li wrote:
> In commit a98ae7f045b2, str_up_down() helper is introduced to
> return "up" or "down" string literal, so we can use it to
> simplify the code and fix the coccinelle warning.
> 
> v2:
>  - change subject into net-next
> 
> v1: https://lore.kernel.org/netdev/20240823162144.GW2164@kernel.org/T/

Thanks, but another problem I raised wrt to v1 still stands.
There is a dependency of this patch that is not present in net-next:
commit a98ae7f045b2 ("lib/string_choices: Add str_up_down() helper").

So I think you will need to repost once that commit has
made it into net-next.
Hongbo Li Aug. 27, 2024, 9:11 a.m. UTC | #2 
On 2024/8/27 16:52, Simon Horman wrote:
> On Tue, Aug 27, 2024 at 10:52:44AM +0800, Hongbo Li wrote:
>> In commit a98ae7f045b2, str_up_down() helper is introduced to
>> return "up" or "down" string literal, so we can use it to
>> simplify the code and fix the coccinelle warning.
>>
>> v2:
>>   - change subject into net-next
>>
>> v1: https://lore.kernel.org/netdev/20240823162144.GW2164@kernel.org/T/
> 
> Thanks, but another problem I raised wrt to v1 still stands.
> There is a dependency of this patch that is not present in net-next:
> commit a98ae7f045b2 ("lib/string_choices: Add str_up_down() helper").
> 
> So I think you will need to repost once that commit has
> made it into net-next.
> 
ok, I'll follow this. This also answer Michal's question.

Thanks,
hongbo