[net-next,0/6] net: ethernet: fs_enet: Cleanup and phylink conversion

Message

Maxime Chevallier Aug. 28, 2024, 9:50 a.m. UTC

This series aims at improving the fs_enet code and port it's PHY
handling from direct phylib access to using phylink instead.

Although this driver is quite old, there are still some users out there,
running an upstream kernel. The development I'm doing is on an MPC885
device, which uses fs_enet, as well as a MPC866-based device.

The main motivation for that work is to eventually support ethernet interfaces
that have more than one PHY attached to the MAC upstream, for which
phylink might be a pre-requisite. That work isn't submitted yet, and the
final solution might not even require phylink.

Regardless, I do believe that this series is relevant, as it does some
cleanup to the driver, and having it use phylink brings some nice
improvements as it simplifies the DT parsing, fixed-link handling and
removes code in that driver that predates even phylib itself.

The series is structured in the following way :

- Patches 1 and 2 are cosmetic changes. The former converts the source
  to SPDX, while the latter has fs_enet-main.c pass checkpatch. Patch 2 is
  really not mandatory in this series, and I understand that this isn't
  the easiest or most pleasant patch to review. OTOH, this allows
  getting a clean checkpatch output for the main part of the driver.

- Patches 3, 4 and 5 drop some leftovers from back when the driver didn't
  use phylib, and brings the use of phylib macros.

- Patch 6 is the actual phylink port, which also cleans the bits of code
  that become irrelevant when using phylink.

Testing was done on an MPC866 and MPC885, any test on other platforms
that use fs_enet are more than welcome.

Thanks,

Maxime

Maxime Chevallier (6):
  net: ethernet: fs_enet: convert to SPDX
  net: ethernet: fs_enet: cosmetic cleanups
  net: ethernet: fs_enet: drop the .adjust_link custom fs_ops
  net: ethernet: fs_enet: drop unused phy_info and mii_if_info
  net: ethernet: fs_enet: fcc: use macros for speed and duplex values
  net: ethernet: fs_enet: phylink conversion

 .../net/ethernet/freescale/fs_enet/Kconfig    |   2 +-
 .../ethernet/freescale/fs_enet/fs_enet-main.c | 421 ++++++++----------
 .../net/ethernet/freescale/fs_enet/fs_enet.h  |  24 +-
 .../net/ethernet/freescale/fs_enet/mac-fcc.c  |  16 +-
 .../net/ethernet/freescale/fs_enet/mac-fec.c  |  14 +-
 .../net/ethernet/freescale/fs_enet/mac-scc.c  |  10 +-
 .../ethernet/freescale/fs_enet/mii-bitbang.c  |   5 +-
 .../net/ethernet/freescale/fs_enet/mii-fec.c  |   5 +-
 8 files changed, 209 insertions(+), 288 deletions(-)

Comments

Christophe Leroy Aug. 28, 2024, 10:10 a.m. UTC | #1

Le 28/08/2024 à 11:50, Maxime Chevallier a écrit :
> This series aims at improving the fs_enet code and port it's PHY
> handling from direct phylib access to using phylink instead.
> 
> Although this driver is quite old, there are still some users out there,
> running an upstream kernel. The development I'm doing is on an MPC885
> device, which uses fs_enet, as well as a MPC866-based device.
> 
> The main motivation for that work is to eventually support ethernet interfaces
> that have more than one PHY attached to the MAC upstream, for which
> phylink might be a pre-requisite. That work isn't submitted yet, and the
> final solution might not even require phylink.
> 
> Regardless, I do believe that this series is relevant, as it does some
> cleanup to the driver, and having it use phylink brings some nice
> improvements as it simplifies the DT parsing, fixed-link handling and
> removes code in that driver that predates even phylib itself.
> 
> The series is structured in the following way :
> 
> - Patches 1 and 2 are cosmetic changes. The former converts the source
>    to SPDX, while the latter has fs_enet-main.c pass checkpatch. Patch 2 is
>    really not mandatory in this series, and I understand that this isn't
>    the easiest or most pleasant patch to review. OTOH, this allows
>    getting a clean checkpatch output for the main part of the driver.
> 
> - Patches 3, 4 and 5 drop some leftovers from back when the driver didn't
>    use phylib, and brings the use of phylib macros.
> 
> - Patch 6 is the actual phylink port, which also cleans the bits of code
>    that become irrelevant when using phylink.
> 
> Testing was done on an MPC866 and MPC885, any test on other platforms
> that use fs_enet are more than welcome.
> 
> Thanks,
> 
> Maxime
> 
> Maxime Chevallier (6):
>    net: ethernet: fs_enet: convert to SPDX
>    net: ethernet: fs_enet: cosmetic cleanups
>    net: ethernet: fs_enet: drop the .adjust_link custom fs_ops
>    net: ethernet: fs_enet: drop unused phy_info and mii_if_info
>    net: ethernet: fs_enet: fcc: use macros for speed and duplex values
>    net: ethernet: fs_enet: phylink conversion

For the series,

Acked-by: Christophe Leroy <[e-mail]> # LINUX FOR 
POWERPC EMBEDDED PPC8XX AND PPC83XX

> 
>   .../net/ethernet/freescale/fs_enet/Kconfig    |   2 +-
>   .../ethernet/freescale/fs_enet/fs_enet-main.c | 421 ++++++++----------
>   .../net/ethernet/freescale/fs_enet/fs_enet.h  |  24 +-
>   .../net/ethernet/freescale/fs_enet/mac-fcc.c  |  16 +-
>   .../net/ethernet/freescale/fs_enet/mac-fec.c  |  14 +-
>   .../net/ethernet/freescale/fs_enet/mac-scc.c  |  10 +-
>   .../ethernet/freescale/fs_enet/mii-bitbang.c  |   5 +-
>   .../net/ethernet/freescale/fs_enet/mii-fec.c  |   5 +-
>   8 files changed, 209 insertions(+), 288 deletions(-)
>