mbox series

[PATCHv6,net-next,0/3] Bonding: support new xfrm state offload functions

Message ID 20240829093133.2596049-1-liuhangbin@gmail.com (mailing list archive)
Headers show
Series Bonding: support new xfrm state offload functions | expand

Message

Hangbin Liu Aug. 29, 2024, 9:31 a.m. UTC
Add 2 new xfrm state offload functions xdo_dev_state_advance_esn and
xdo_dev_state_update_stats for bonding. The xdo_dev_state_free will be
added by Jianbo's patchset [1]. I will add the bonding xfrm policy offload
in future.

v6: Use "Return: " based on ./scripts/kernel-doc (Simon Horman)
v5: Rebase to latest net-next, update function doc (Jakub Kicinski)
v4: Ratelimit pr_warn (Sabrina Dubroca)
v3: Re-format bond_ipsec_dev, use slave_warn instead of WARN_ON (Nikolay Aleksandrov)
    Fix bond_ipsec_dev defination, add *. (Simon Horman, kernel test robot)
    Fix "real" typo (kernel test robot)
v2: Add a function to process the common device checking (Nikolay Aleksandrov)
    Remove unused variable (Simon Horman)
v1: lore.kernel.org/netdev/20240816035518.203704-1-liuhangbin@gmail.com

Hangbin Liu (3):
  bonding: add common function to check ipsec device
  bonding: Add ESN support to IPSec HW offload
  bonding: support xfrm state update

 drivers/net/bonding/bond_main.c | 100 +++++++++++++++++++++++++++-----
 1 file changed, 87 insertions(+), 13 deletions(-)

Comments

Hangbin Liu Sept. 3, 2024, 7:10 a.m. UTC | #1
Hi Jakub,

I saw the patchwork status[1] is Not Applicable. Is there anything I need
to update?

[1] https://patchwork.kernel.org/project/netdevbpf/patch/20240829093133.2596049-2-liuhangbin@gmail.com/

Thanks
Hangbin

On Thu, Aug 29, 2024 at 05:31:30PM +0800, Hangbin Liu wrote:
> Add 2 new xfrm state offload functions xdo_dev_state_advance_esn and
> xdo_dev_state_update_stats for bonding. The xdo_dev_state_free will be
> added by Jianbo's patchset [1]. I will add the bonding xfrm policy offload
> in future.
> 
> v6: Use "Return: " based on ./scripts/kernel-doc (Simon Horman)
> v5: Rebase to latest net-next, update function doc (Jakub Kicinski)
> v4: Ratelimit pr_warn (Sabrina Dubroca)
> v3: Re-format bond_ipsec_dev, use slave_warn instead of WARN_ON (Nikolay Aleksandrov)
>     Fix bond_ipsec_dev defination, add *. (Simon Horman, kernel test robot)
>     Fix "real" typo (kernel test robot)
> v2: Add a function to process the common device checking (Nikolay Aleksandrov)
>     Remove unused variable (Simon Horman)
> v1: lore.kernel.org/netdev/20240816035518.203704-1-liuhangbin@gmail.com
> 
> Hangbin Liu (3):
>   bonding: add common function to check ipsec device
>   bonding: Add ESN support to IPSec HW offload
>   bonding: support xfrm state update
> 
>  drivers/net/bonding/bond_main.c | 100 +++++++++++++++++++++++++++-----
>  1 file changed, 87 insertions(+), 13 deletions(-)
> 
> -- 
> 2.45.0
>
Jakub Kicinski Sept. 3, 2024, 3:56 p.m. UTC | #2
On Tue, 3 Sep 2024 15:10:48 +0800 Hangbin Liu wrote:
> I saw the patchwork status[1] is Not Applicable. Is there anything I need
> to update?

Majority of the time seemingly inexplicable Not Applicable status means
that DaveM tried to apply the patches and git am failed. Seems to be
the case here as well:

Failed to apply patch:
Applying: bonding: add common function to check ipsec device
Applying: bonding: Add ESN support to IPSec HW offload
error: sha1 information is lacking or useless (drivers/net/bonding/bond_main.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 bonding: Add ESN support to IPSec HW offload
Hangbin Liu Sept. 4, 2024, 12:33 a.m. UTC | #3
On Tue, Sep 03, 2024 at 08:56:47AM -0700, Jakub Kicinski wrote:
> On Tue, 3 Sep 2024 15:10:48 +0800 Hangbin Liu wrote:
> > I saw the patchwork status[1] is Not Applicable. Is there anything I need
> > to update?
> 
> Majority of the time seemingly inexplicable Not Applicable status means
> that DaveM tried to apply the patches and git am failed. Seems to be
> the case here as well:

Hi Jakub,

Thanks let me know this. Looks git rebase works but git am failed
due to the xdo_dev_state_free update.

.xdo_dev_state_free = bond_ipsec_free_sa,

Let me rebase and post again.

Hangbin

> 
> Failed to apply patch:
> Applying: bonding: add common function to check ipsec device
> Applying: bonding: Add ESN support to IPSec HW offload
> error: sha1 information is lacking or useless (drivers/net/bonding/bond_main.c).
> error: could not build fake ancestor
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> hint: When you have resolved this problem, run "git am --continue".
> hint: If you prefer to skip this patch, run "git am --skip" instead.
> hint: To restore the original branch and stop patching, run "git am --abort".
> hint: Disable this message with "git config advice.mergeConflict false"
> Patch failed at 0002 bonding: Add ESN support to IPSec HW offload
>