mbox series

[net-next,0/6] net: ibm: emac: some cleanups and devm

Message ID 20240902181530.6852-1-rosenp@gmail.com (mailing list archive)
Headers show
Series net: ibm: emac: some cleanups and devm | expand

Message

Rosen Penev Sept. 2, 2024, 6:15 p.m. UTC 
It's a very old driver with a lot of potential for cleaning up code to
modern standards. This was a simple one dealing with mostly the probe
function and adding some devm to it.

All patches were tested on a Cisco Meraki MX60W. Boot and
Shutdown/Reboot showed no warnings.

Rosen Penev (6):
  net: ibm: emac: use devm for alloc_etherdev
  net: ibm: emac: manage emac_irq with devm
  net: ibm: emac: use devm for of_iomap
  net: ibm: emac: remove mii_bus with devm
  net: ibm: emac: use devm for register_netdev
  net: ibm: emac: use netdev's phydev directly

 drivers/net/ethernet/ibm/emac/core.c | 130 +++++++++++----------------
 drivers/net/ethernet/ibm/emac/core.h |   4 -
 2 files changed, 50 insertions(+), 84 deletions(-)

Comments

Andrew Lunn Sept. 2, 2024, 8 p.m. UTC | #1 
On Mon, Sep 02, 2024 at 11:15:09AM -0700, Rosen Penev wrote:
> It's a very old driver with a lot of potential for cleaning up code to
> modern standards. This was a simple one dealing with mostly the probe
> function and adding some devm to it.
> 
> All patches were tested on a Cisco Meraki MX60W. Boot and
> Shutdown/Reboot showed no warnings.

This is a 12 year old PowerPC system. Cool you found one. Looks like
OpenWRT still supports it.

	Andrwq
Rosen Penev Sept. 2, 2024, 8:20 p.m. UTC | #2 
On Mon, Sep 2, 2024 at 1:00 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, Sep 02, 2024 at 11:15:09AM -0700, Rosen Penev wrote:
> > It's a very old driver with a lot of potential for cleaning up code to
> > modern standards. This was a simple one dealing with mostly the probe
> > function and adding some devm to it.
> >
> > All patches were tested on a Cisco Meraki MX60W. Boot and
> > Shutdown/Reboot showed no warnings.
>
> This is a 12 year old PowerPC system. Cool you found one. Looks like
> OpenWRT still supports it.
I recently bought one in an attempt to get qca8k working on it.
Unfortunately the bootloader disables all ports except WAN and the
driver has a hack that disables MDIO 0-3, which qca8k seems to need. I
tried removing it but then mdiobus_alloc fails with error code -5.

qca8k only manages to bring up port 5 (WAN).
>
>         Andrwq