| Message ID | 20240903135327.2810535-1-idosch@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Unmask upper DSCP bits - part 3 | expand |
On 9/3/24 7:53 AM, Ido Schimmel wrote: > tl;dr - This patchset continues to unmask the upper DSCP bits in the > IPv4 flow key in preparation for allowing IPv4 FIB rules to match on > DSCP. No functional changes are expected. > > The TOS field in the IPv4 flow key ('flowi4_tos') is used during FIB > lookup to match against the TOS selector in FIB rules and routes. > > It is currently impossible for user space to configure FIB rules that > match on the DSCP value as the upper DSCP bits are either masked in the > various call sites that initialize the IPv4 flow key or along the path > to the FIB core. > > In preparation for adding a DSCP selector to IPv4 and IPv6 FIB rules, we > need to make sure the entire DSCP value is present in the IPv4 flow key. > This patchset continues to unmask the upper DSCP bits, but this time in > the output route path, specifically in the callers of > ip_route_output_ports(). > > The next patchset (last) will handle the callers of > ip_route_output_key(). Split from this patchset to avoid going over the > 15 patches limit. > > No functional changes are expected as commit 1fa3314c14c6 ("ipv4: > Centralize TOS matching") moved the masking of the upper DSCP bits to > the core where 'flowi4_tos' is matched against the TOS selector. > > Ido Schimmel (4): > ipv4: Unmask upper DSCP bits in __ip_queue_xmit() > ipv4: ipmr: Unmask upper DSCP bits in ipmr_queue_xmit() > ip6_tunnel: Unmask upper DSCP bits in ip4ip6_err() > ipv6: sit: Unmask upper DSCP bits in ipip6_tunnel_bind_dev() > > net/ipv4/ip_output.c | 2 +- > net/ipv4/ipmr.c | 4 ++-- > net/ipv6/ip6_tunnel.c | 7 +++++-- > net/ipv6/sit.c | 2 +- > 4 files changed, 9 insertions(+), 6 deletions(-) > For the set: Reviewed-by: David Ahern <dsahern@kernel.org>
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 3 Sep 2024 16:53:23 +0300 you wrote: > tl;dr - This patchset continues to unmask the upper DSCP bits in the > IPv4 flow key in preparation for allowing IPv4 FIB rules to match on > DSCP. No functional changes are expected. > > The TOS field in the IPv4 flow key ('flowi4_tos') is used during FIB > lookup to match against the TOS selector in FIB rules and routes. > > [...] Here is the summary with links: - [net-next,1/4] ipv4: Unmask upper DSCP bits in __ip_queue_xmit() https://git.kernel.org/netdev/net-next/c/71f1fea4f65d - [net-next,2/4] ipv4: ipmr: Unmask upper DSCP bits in ipmr_queue_xmit() https://git.kernel.org/netdev/net-next/c/97edbbaad303 - [net-next,3/4] ip6_tunnel: Unmask upper DSCP bits in ip4ip6_err() https://git.kernel.org/netdev/net-next/c/de1fb3e8b053 - [net-next,4/4] ipv6: sit: Unmask upper DSCP bits in ipip6_tunnel_bind_dev() https://git.kernel.org/netdev/net-next/c/c9a1e2629d10 You are awesome, thank you!
tl;dr - This patchset continues to unmask the upper DSCP bits in the IPv4 flow key in preparation for allowing IPv4 FIB rules to match on DSCP. No functional changes are expected. The TOS field in the IPv4 flow key ('flowi4_tos') is used during FIB lookup to match against the TOS selector in FIB rules and routes. It is currently impossible for user space to configure FIB rules that match on the DSCP value as the upper DSCP bits are either masked in the various call sites that initialize the IPv4 flow key or along the path to the FIB core. In preparation for adding a DSCP selector to IPv4 and IPv6 FIB rules, we need to make sure the entire DSCP value is present in the IPv4 flow key. This patchset continues to unmask the upper DSCP bits, but this time in the output route path, specifically in the callers of ip_route_output_ports(). The next patchset (last) will handle the callers of ip_route_output_key(). Split from this patchset to avoid going over the 15 patches limit. No functional changes are expected as commit 1fa3314c14c6 ("ipv4: Centralize TOS matching") moved the masking of the upper DSCP bits to the core where 'flowi4_tos' is matched against the TOS selector. Ido Schimmel (4): ipv4: Unmask upper DSCP bits in __ip_queue_xmit() ipv4: ipmr: Unmask upper DSCP bits in ipmr_queue_xmit() ip6_tunnel: Unmask upper DSCP bits in ip4ip6_err() ipv6: sit: Unmask upper DSCP bits in ipip6_tunnel_bind_dev() net/ipv4/ip_output.c | 2 +- net/ipv4/ipmr.c | 4 ++-- net/ipv6/ip6_tunnel.c | 7 +++++-- net/ipv6/sit.c | 2 +- 4 files changed, 9 insertions(+), 6 deletions(-)