mbox series

[net,RESEND,0/3] net: Use IRQF_NO_AUTOEN flag in request_irq()

Message ID 20240911094445.1922476-1-ruanjinjie@huawei.com (mailing list archive)
Headers show
Series net: Use IRQF_NO_AUTOEN flag in request_irq() | expand

Message

Jinjie Ruan Sept. 11, 2024, 9:44 a.m. UTC
As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
said, reqeust_irq() and then disable_irq() is unsafe.

IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents
the automatic enabling of the requested interrupt in the same safe way.
With that the usage can be simplified and corrected.

Only compile-tested.

v1 -> RESNED
- Add reviewed-by.
- Put wireless into another patch set.
- Update to net prefix subject.

Jinjie Ruan (3):
  net: apple: bmac: Use IRQF_NO_AUTOEN flag in request_irq()
  net: enetc: Use IRQF_NO_AUTOEN flag in request_irq()
  nfp: Use IRQF_NO_AUTOEN flag in request_irq()

 drivers/net/ethernet/apple/bmac.c                   | 3 +--
 drivers/net/ethernet/freescale/enetc/enetc.c        | 3 +--
 drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 5 ++---
 3 files changed, 4 insertions(+), 7 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 13, 2024, 3:50 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 11 Sep 2024 17:44:42 +0800 you wrote:
> As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
> said, reqeust_irq() and then disable_irq() is unsafe.
> 
> IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents
> the automatic enabling of the requested interrupt in the same safe way.
> With that the usage can be simplified and corrected.
> 
> [...]

Here is the summary with links:
  - [net,RESEND,1/3] net: apple: bmac: Use IRQF_NO_AUTOEN flag in request_irq()
    https://git.kernel.org/netdev/net-next/c/e08ec0597bad
  - [net,RESEND,2/3] net: enetc: Use IRQF_NO_AUTOEN flag in request_irq()
    https://git.kernel.org/netdev/net-next/c/799a92259977
  - [net,RESEND,3/3] nfp: Use IRQF_NO_AUTOEN flag in request_irq()
    https://git.kernel.org/netdev/net-next/c/daaba19d357f

You are awesome, thank you!