[net-next,v3,0/4] Refactoring RVU NIC driver

Message

Geetha sowjanya Sept. 12, 2024, 6:40 a.m. UTC

This is a preparation pathset for follow-up "Introducing RVU representors driver"
patches. The RVU representor driver creates representor netdev of each rvu device
when switch dev mode is enabled.
 
RVU representor and NIC have a similar set of HW resources(NIX_LF,RQ/SQ/CQ)
and implements a subset of NIC functionality.
This patch set groups hw resources and queue configuration code into single API 
and export the existing functions so, that code can be shared between NIC and
representor drivers.

These patches are part of "Introduce RVU representors" patchset. 
https://lore.kernel.org/all/[e-mail]/T/
As suggested by "Jiri Pirko", submitting as separate patchset.

v2-v3:
 - Added review tags.

v1-v2:
- Removed unwanted variable.
- Dropped unrelated changes from patch4.

Geetha sowjanya (4):
  octeontx2-pf: Define common API for HW resources configuration
  octeontx2-pf: Add new APIs for queue memory alloc/free.
  octeontx2-pf: Reuse PF max mtu value
  octeontx2-pf: Export common APIs

 .../marvell/octeontx2/nic/otx2_common.c       |   6 +-
 .../marvell/octeontx2/nic/otx2_common.h       |  15 ++
 .../ethernet/marvell/octeontx2/nic/otx2_pf.c  | 239 +++++++++++-------
 .../ethernet/marvell/octeontx2/nic/otx2_vf.c  |   5 +-
 4 files changed, 170 insertions(+), 95 deletions(-)

Comments

Jakub Kicinski Sept. 14, 2024, 4:26 a.m. UTC | #1

On Thu, 12 Sep 2024 12:10:13 +0530 Geetha sowjanya wrote:
> These patches are part of "Introduce RVU representors" patchset. 
> https://lore.kernel.org/all/[e-mail]/T/
> As suggested by "Jiri Pirko", submitting as separate patchset.

Changes look good, but you also have to remove the EXPORTs.
Kernel has a general policy of not exporting functions
if there is no in-tree caller that needs the exports.