mbox series

[net-next,0/8] net: smsc911x: clean up with devm

Message ID 20240930224056.354349-1-rosenp@gmail.com (mailing list archive)
Headers show
Series net: smsc911x: clean up with devm | expand

Message

Rosen Penev Sept. 30, 2024, 10:40 p.m. UTC 
It happens to fix missing frees, especially with mdiobus functions.

Rosen Penev (8):
  net: smsc911x: use devm_platform_ioremap_resource
  net: smsc911x: use devm_alloc_etherdev
  net: smsc911x: use devm for regulators
  net: smsc911x: use devm for mdiobus functions
  net: smsc911x: use devm for register_netdev
  net: smsc911x: remove debug stuff from _remove
  net: smsc91xx: move down struct members
  net: smsc911x: remove pointless NULL checks

 drivers/net/ethernet/smsc/smsc911x.c | 216 ++++-----------------------
 1 file changed, 28 insertions(+), 188 deletions(-)

Comments

Jakub Kicinski Oct. 2, 2024, 12:32 p.m. UTC | #1 
On Mon, 30 Sep 2024 15:40:48 -0700 Rosen Penev wrote:
> It happens to fix missing frees, especially with mdiobus functions.

Do you have the real hardware and have you tested this on it?

Please always include such information in the commit message.
Random conversions to devm are discouraged in networking.
Rosen Penev Oct. 2, 2024, 7:17 p.m. UTC | #2 
On Wed, Oct 2, 2024 at 5:32 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 30 Sep 2024 15:40:48 -0700 Rosen Penev wrote:
> > It happens to fix missing frees, especially with mdiobus functions.
>
> Do you have the real hardware and have you tested this on it?
>
> Please always include such information in the commit message.
> Random conversions to devm are discouraged in networking.
That's unfortunate.