mbox series

[v3,0/2] resolve gtp possible deadlock warning

Message ID 20241014073038.27215-1-danielyangkang@gmail.com (mailing list archive)
Headers show
Series resolve gtp possible deadlock warning | expand

Message

Daniel Yang Oct. 14, 2024, 7:30 a.m. UTC 
Fixes deadlock described in this bug:
https://syzkaller.appspot.com/bug?extid=e953a8f3071f5c0a28fd.
Specific crash report here:
https://syzkaller.appspot.com/text?tag=CrashReport&x=14670e07980000.

This bug is a false positive lockdep warning since gtp and smc use
completely different socket protocols.

Lockdep thinks that lock_sock() in smc will deadlock with gtp's
lock_sock() acquisition.

Adding lockdep annotations on smc socket creation prevents these false
positives.

Daniel Yang (2):
  Patch from D. Wythe <alibuda@linux.alibaba.com>
  Move lockdep annotation to separate function for readability.

 net/smc/smc_inet.c | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

Comments

Jakub Kicinski Oct. 15, 2024, 5:54 p.m. UTC | #1 
On Mon, 14 Oct 2024 00:30:36 -0700 Daniel Yang wrote:
> Fixes deadlock described in this bug:
> https://syzkaller.appspot.com/bug?extid=e953a8f3071f5c0a28fd.
> Specific crash report here:
> https://syzkaller.appspot.com/text?tag=CrashReport&x=14670e07980000.
> 
> This bug is a false positive lockdep warning since gtp and smc use
> completely different socket protocols.
> 
> Lockdep thinks that lock_sock() in smc will deadlock with gtp's
> lock_sock() acquisition.
> 
> Adding lockdep annotations on smc socket creation prevents these false
> positives.

This posting looks corrupted, please fix and repost, if it's 
not accidental.