mbox series

[net,v2,0/4] net: stmmac: dwmac4: Fixes bugs in dwmac4

Message ID 20241016031832.3701260-1-leyfoon.tan@starfivetech.com (mailing list archive)
Headers show
Series net: stmmac: dwmac4: Fixes bugs in dwmac4 | expand

Message

Ley Foon Tan Oct. 16, 2024, 3:18 a.m. UTC 
This patch series fix the bugs in dwmac4 drivers.

Changes since v1:
- Removed empty line between Fixes and Signoff
- Rebased to https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
- Updated git commit description for patch 4/4

History:
v1: https://patchwork.kernel.org/project/netdevbpf/cover/20241015065708.3465151-1-leyfoon.tan@starfivetech.com/

Ley Foon Tan (4):
  net: stmmac: dwmac4: Fix MTL_OP_MODE_RTC mask and shift macros
  net: stmmac: dwmac4: Fix the MTL_OP_MODE_*_MASK operation
  net: stmmac: dwmac4: Receive Watchdog Timeout is not in abnormal
    interrupt summary
  net: stmmac: dwmac4: Fix high address display by updating reg_space[]
    from register values

 drivers/net/ethernet/stmicro/stmmac/dwmac4.h     |  4 ++--
 drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c | 12 ++++++++++--
 drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h |  2 ++
 drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c |  6 ++++--
 4 files changed, 18 insertions(+), 6 deletions(-)

Comments

Simon Horman Oct. 17, 2024, 2:09 p.m. UTC | #1 
On Wed, Oct 16, 2024 at 11:18:28AM +0800, Ley Foon Tan wrote:
> This patch series fix the bugs in dwmac4 drivers.
> 
> Changes since v1:
> - Removed empty line between Fixes and Signoff
> - Rebased to https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
> - Updated git commit description for patch 4/4
> 
> History:
> v1: https://patchwork.kernel.org/project/netdevbpf/cover/20241015065708.3465151-1-leyfoon.tan@starfivetech.com/

Hi,

Thanks for the update and sorry for not providing more timely feedback.

I think that the code changes themselves look fine. However,
as a rule of thumb, fixes for net should resolve user-visible problems.
I see that is the case for patch 4/4, but it is less clear to me
for the other 3 patches. If it is indeed then I think it would be good
to explain that more clearly in their patch descriptions.

If not, perhaps they should be submitted to net-next without Fixes tags
while patch 4 and any others that are still fixes resubmitted as a smaller
v3 patch-set for net.

...