[v3,0/2] PtP driver for s390 clocks

Message

Sven Schnelle Oct. 17, 2024, 6:07 a.m. UTC

Hi,

these patches add support for using the s390 physical and TOD clock as ptp
clock. To do so, the first patch adds a clock id to the s390 TOD clock,
while the second patch adds the PtP driver itself.

Changes in v3:
- drop 'IBM' from clock names
- use u128 as return type of eitod_to_ns()
- fix calculation in eitod_to_timespec64()

Changes in v2:
- add missing MODULE_DESCRIPTION()
- drop udev event patch
- simplify eitod_to_ns()
- use store_tod_clock_ext() instead of store_tod_clock_ext_cc()
- move stp_enabled() declaration to stp.h
- use s390 instead of 'Z' in clock names
- defconfig symbol should be default-n

Sven Schnelle (2):
  s390/time: Add clocksource id to TOD clock
  s390/time: Add PtP driver

 MAINTAINERS                     |   6 ++
 arch/s390/include/asm/stp.h     |   1 +
 arch/s390/include/asm/timex.h   |   6 ++
 arch/s390/kernel/time.c         |   7 ++
 drivers/ptp/Kconfig             |  11 +++
 drivers/ptp/Makefile            |   1 +
 drivers/ptp/ptp_s390.c          | 129 ++++++++++++++++++++++++++++++++
 include/linux/clocksource_ids.h |   1 +
 8 files changed, 162 insertions(+)
 create mode 100644 drivers/ptp/ptp_s390.c

Comments

Heiko Carstens Oct. 17, 2024, 9:46 a.m. UTC | #1

On Thu, Oct 17, 2024 at 08:07:47AM +0200, Sven Schnelle wrote:
> Hi,
> 
> these patches add support for using the s390 physical and TOD clock as ptp
> clock. To do so, the first patch adds a clock id to the s390 TOD clock,
> while the second patch adds the PtP driver itself.
...
>  MAINTAINERS                     |   6 ++
>  arch/s390/include/asm/stp.h     |   1 +
>  arch/s390/include/asm/timex.h   |   6 ++
>  arch/s390/kernel/time.c         |   7 ++
>  drivers/ptp/Kconfig             |  11 +++
>  drivers/ptp/Makefile            |   1 +
>  drivers/ptp/ptp_s390.c          | 129 ++++++++++++++++++++++++++++++++
>  include/linux/clocksource_ids.h |   1 +
>  8 files changed, 162 insertions(+)
>  create mode 100644 drivers/ptp/ptp_s390.c

As far as I am concerned:
Acked-by: Heiko Carstens <[e-mail]>

Richard, if this looks good for you too, how should this go upstream?
We could carry this via the s390 tree, if you want.

Richard Cochran Oct. 17, 2024, 2:06 p.m. UTC | #2

On Thu, Oct 17, 2024 at 11:46:06AM +0200, Heiko Carstens wrote:

> Richard, if this looks good for you too, how should this go upstream?
> We could carry this via the s390 tree, if you want.

PTP drivers normally go through net-next.

Thanks,
Richard

Richard Cochran Oct. 17, 2024, 2:06 p.m. UTC | #3

On Thu, Oct 17, 2024 at 08:07:47AM +0200, Sven Schnelle wrote:
> Hi,
> 
> these patches add support for using the s390 physical and TOD clock as ptp
> clock. To do so, the first patch adds a clock id to the s390 TOD clock,
> while the second patch adds the PtP driver itself.

For the series:

Acked-by: Richard Cochran <[e-mail]>