[PATCHv8,net-next,0/5] ibm: emac: more cleanups

Message

Rosen Penev Oct. 22, 2024, 12:22 a.m. UTC

Tested on Cisco MX60W.

v2: fixed build errors. Also added extra commits to clean the driver up
further.
v3: Added tested message. Removed bad alloc_netdev_dummy commit.
v4: removed modules changes from patchset. Added fix for if MAC not
found.
v5: added of_find_matching_node commit.
v6: resend after net-next merge.
v7: removed of_find_matching_node commit. Adjusted mutex_init patch.
v8: removed patch removing custom init/exit. Needs more work.

Rosen Penev (5):
  net: ibm: emac: use netif_receive_skb_list
  net: ibm: emac: use devm_platform_ioremap_resource
  net: ibm: emac: use platform_get_irq
  net: ibm: emac: use devm for mutex_init
  net: ibm: emac: generate random MAC if not found

 drivers/net/ethernet/ibm/emac/core.c | 42 +++++++++++++++-------------
 1 file changed, 22 insertions(+), 20 deletions(-)

Comments

Nelson, Shannon Oct. 22, 2024, 12:50 a.m. UTC | #1

On 10/21/2024 5:22 PM, Rosen Penev wrote:
> 
> Tested on Cisco MX60W.
> 
> v2: fixed build errors. Also added extra commits to clean the driver up
> further.
> v3: Added tested message. Removed bad alloc_netdev_dummy commit.
> v4: removed modules changes from patchset. Added fix for if MAC not
> found.
> v5: added of_find_matching_node commit.
> v6: resend after net-next merge.
> v7: removed of_find_matching_node commit. Adjusted mutex_init patch.
> v8: removed patch removing custom init/exit. Needs more work.
> 
> Rosen Penev (5):
>    net: ibm: emac: use netif_receive_skb_list
>    net: ibm: emac: use devm_platform_ioremap_resource
>    net: ibm: emac: use platform_get_irq
>    net: ibm: emac: use devm for mutex_init
>    net: ibm: emac: generate random MAC if not found
> 
>   drivers/net/ethernet/ibm/emac/core.c | 42 +++++++++++++++-------------
>   1 file changed, 22 insertions(+), 20 deletions(-)
> 
> --
> 2.47.0
> 

These look reasonable - thanks.

Reviewed-by: Shannon Nelson <[e-mail]>