mbox series

[v4,0/2] vsock/test: fix wrong setsockopt() parameters

Message ID 20241029144954.285279-1-kshk@linux.ibm.com (mailing list archive)
Headers show
Series vsock/test: fix wrong setsockopt() parameters | expand

Message

Konstantin Shkolnyy Oct. 29, 2024, 2:49 p.m. UTC
Parameters were created using wrong C types, which caused them to be of
wrong size on some architectures, causing problems.

The problem with SO_RCVLOWAT was found on s390 (big endian), while x86-64
didn't show it. After the fix, all tests pass on s390.
Then Stefano Garzarella pointed out that SO_VM_SOCKETS_* calls might have
a similar problem, which turned out to be true, hence, the second patch.

Changes for v4:
- add "Reviewed-by:" to the first patch, and add a second patch fixing
SO_VM_SOCKETS_* calls, which depends on the first one (hence, it's now
a patch series.)
Changes for v3:
- fix the same problem in vsock_perf and update commit message
Changes for v2:
- add "Fixes:" lines to the commit message

Konstantin Shkolnyy (2):
  vsock/test: fix failures due to wrong SO_RCVLOWAT parameter
  vsock/test: fix parameter types in SO_VM_SOCKETS_* calls

 tools/testing/vsock/vsock_perf.c |  8 ++++----
 tools/testing/vsock/vsock_test.c | 23 ++++++++++++++++-------
 2 files changed, 20 insertions(+), 11 deletions(-)