From patchwork Wed Nov 6 17:37:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Polchlopek X-Patchwork-Id: 13864425 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E493657333 for ; Wed, 6 Nov 2024 11:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730893071; cv=none; b=ISTjblv5FCwIwbPnTEx2WyHrk5m10EwuDYRsdGQDxrfS+g1lDfks59TJxn+w1ic4XvOEyEUNv0SWaZrSfPJrAHpeutwHjrLhBnAlEfoDUEMGlBzi5Hig2yZQdoPE2hfU42sMjdiOxza20fercdP6km9fB97WbKFBfg4IOy8TC9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730893071; c=relaxed/simple; bh=R3UcfVcEoY2Q3PMzAqNdlN8eSsaPRv6104q206PTkcE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=PgGRAcuHY4a4NFXnPtTAzqXFSNuc3AXVqWz2lUJLUVAR51JcJLcH+4hkk9ITdzHjR3ceYEM556tuCtkxjFVuOwe0dYtnGq+u//Tc2BjxC3ZvUZR1hnfMfbTdf6f6YHLGlPC4rQXEu2EEM5iXedWLkOGmyv0GyBcGmaJxlrSzbss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SaZZLia3; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SaZZLia3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730893069; x=1762429069; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=R3UcfVcEoY2Q3PMzAqNdlN8eSsaPRv6104q206PTkcE=; b=SaZZLia3dSDM3132mmvBu0cJynh8MWkk6hj8mqOaCEb1WX0ZofcqUITX 3fMhA2IcSzeGy4hpSOoibZ45xZmlpGuXdK6V3r0EaHsTB9i3ma3Z8q27F 1XVdUNQVNtkAV4HAQDyhCX4yi1RpM//Zqt5heKyzH92YhprXbaE4hCMnr UBCmwxaSZHiAVuafHbNKthdMWAZN+bxsXufAh9sGy/JwboiLS02yndacV TPz30CmF2+ghfeke1QPh+9OfOIpbKCNG7WVcX/GIUI2qVty8txDdqwJUB UWhwpb8F1EyaV+Qf455t+87v86ntMqeKu7YPudsLu0p75BJAh0fux7iwM w==; X-CSE-ConnectionGUID: lxeJ6RPzRNukWriVyZ8zcQ== X-CSE-MsgGUID: 7KWor9ANTtie1gjc8l1AYg== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="30455485" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="30455485" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2024 03:37:48 -0800 X-CSE-ConnectionGUID: RhJ+TEa5TQW3T1QhyE3xsQ== X-CSE-MsgGUID: YpE/fHIgRUi/cVDYXGUg3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,262,1725346800"; d="scan'208";a="122020108" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by orviesa001.jf.intel.com with ESMTP; 06 Nov 2024 03:37:46 -0800 Received: from fedora.igk.intel.com (Metan_eth.igk.intel.com [10.123.220.124]) by irvmail002.ir.intel.com (Postfix) with ESMTP id 8AAA228169; Wed, 6 Nov 2024 11:37:45 +0000 (GMT) From: Mateusz Polchlopek To: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, Mateusz Polchlopek Subject: [Intel-wired-lan] [PATCH iwl-next v13 00/14] Add support for Rx timestamping for both ice and iavf drivers Date: Wed, 6 Nov 2024 12:37:17 -0500 Message-Id: <20241106173731.4272-1-mateusz.polchlopek@intel.com> X-Mailer: git-send-email 2.38.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Initially, during VF creation it registers the PTP clock in the system and negotiates with PF it's capabilities. In the meantime the PF enables the Flexible Descriptor for VF. Only this type of descriptor allows to receive Rx timestamps. Enabling virtual clock would be possible, though it would probably perform poorly due to the lack of direct time access. Enable timestamping should be done using userspace tools, e.g. hwstamp_ctl -i $VF -r 14 In order to report the timestamps to userspace, the VF extends timestamp to 40b. To support this feature the flexible descriptors and PTP part in iavf driver have been introduced. --- v13: - cosmetic changes - added dependency to PTP_1588_CLOCK_OPTIONAL in Kconfig (patch 6) to prevent compilation warnings and added Tested-by tags. No logical and deeper changes in code. v12: - small changes versus v11, fixed compilation warnings and errors and covered Vadim's request about ptp_read_system_prets and ptp_read_system_postts() in iavf_read_phc_indirect() function. Added stubs in iavf_ptp.h file depends on CONFIG_PTP_1588_CLOCK config option. https://lore.kernel.org/netdev/20241022114121.61284-1-mateusz.polchlopek@intel.com/ v11: - addressed all comments from v10 done by Alexander L. Short list: changed some logging functions (like pci_warn instead of dev_warn), fix RCT, fix indentation, remove unnecessary comments and casts, change error codes where applicable, remove ptp.initialized field in struct (now check for ptp.clock as Olek suggested), invert condition in few places to avoid +1 indent level, function iavf_ptp_do_aux_work made as static, add more descriptive kdoc for libeth struct fields, restore ptype as a field in libeth struct, remove unused defines, pass to specific functions quad word of descriptor instead of pass rx_desc, add asserts to structs where applicable, return from fields extracting functions when !fields.eop, refactor get VLAN tags, remove unnecessary empty initialization of structs and few more. Please see v10 to compare all changes. https://lore.kernel.org/netdev/20241013154415.20262-1-mateusz.polchlopek@intel.com/ v10: - only cosmetic changes, make every patch compile, fixing checkpatch issues https://lore.kernel.org/netdev/20240821121539.374343-1-wojciech.drewek@intel.com/ v9: - another big refactor of code, again the list is too long to describe each change. Only patch1 and patch12 has not been changed AFAIR. Please take a look on v8 and changes requests from Alexander L. (in short - fixed structs paddings, aligns, optimized rx hot path, renamed few structs, added "const" keyword where applicable, added kdoc comments to newly introduced structs and defines, removed unnecessary casts, simplified few functions and few more). https://lore.kernel.org/netdev/20240813125513.8212-1-mateusz.polchlopek@intel.com/ v8: - big refactor to make code more optimised (too many changes to list them here, please take a look on v7 patch9 and comments from Alexander L) - patch 11. Because of that I decided to remove all gathered RB tags. - changed newly introduced spinlock aq_cmd_lock to mutex type to avoid deadlock - patch 7 - adjusted function iavf_is_descriptor_done() to extract fields from descriptor in a new way - patch 12 - changed (and removed unused) defines that describe specific fields and bits in descriptor https://lore.kernel.org/netdev/20240730091509.18846-1-mateusz.polchlopek@intel.com/ v7: - changed .ndo_eth_ioctl to .ndo_hwtstamp_get and .ndo_hwtstamp_set (according to Kuba's suggestion) - patch 11 https://lore.kernel.org/netdev/20240604131400.13655-1-mateusz.polchlopek@intel.com/ v6: - reordered tags - added RB tags where applicable - removed redundant instructions in ifs - patch 4 and patch 5 - changed teardown to LIFO, adapter->ptp.initialized = false moved to the top of function - patch 6 - changed cpu-endianess for testing - patch 9 - aligned to libeth changes - patch 9 https://lore.kernel.org/netdev/20240528112301.5374-1-mateusz.polchlopek@intel.com/ v5: - fixed all new issues generated by this series in kernel-doc https://lore.kernel.org/netdev/20240418052500.50678-1-mateusz.polchlopek@intel.com/ v4: - fixed duplicated argument in iavf_virtchnl.c reported by coccicheck https://lore.kernel.org/netdev/20240410121706.6223-1-mateusz.polchlopek@intel.com/ v3: - added RB in commit 6 - removed inline keyword in commit 9 - fixed sparse issues in commit 9 and commit 10 - used GENMASK_ULL when possible in commit 9 https://lore.kernel.org/netdev/20240403131927.87021-1-mateusz.polchlopek@intel.com/ v2: - fixed warning related to wrong specifier to dev_err_once in commit 7 - fixed warnings related to unused variables in commit 9 https://lore.kernel.org/netdev/20240327132543.15923-1-mateusz.polchlopek@intel.com/ v1: - initial series https://lore.kernel.org/netdev/20240326115116.10040-1-mateusz.polchlopek@intel.com/ --- Jacob Keller (10): virtchnl: add support for enabling PTP on iAVF virtchnl: add enumeration for the rxdid format iavf: add support for negotiating flexible RXDID format iavf: negotiate PTP capabilities iavf: add initial framework for registering PTP clock iavf: add support for indirect access to PHC time iavf: periodically cache PHC time iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors iavf: handle set and get timestamps ops iavf: add support for Rx timestamps to hotpath Mateusz Polchlopek (3): libeth: move idpf_rx_csum_decoded and idpf_rx_extracted iavf: define Rx descriptors as qwords iavf: Implement checking DD desc field Simei Su (1): ice: support Rx timestamp on flex descriptor drivers/net/ethernet/intel/Kconfig | 1 + drivers/net/ethernet/intel/iavf/Makefile | 2 + drivers/net/ethernet/intel/iavf/iavf.h | 35 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 228 +++++++- drivers/net/ethernet/intel/iavf/iavf_ptp.c | 485 ++++++++++++++++++ drivers/net/ethernet/intel/iavf/iavf_ptp.h | 47 ++ drivers/net/ethernet/intel/iavf/iavf_trace.h | 6 +- drivers/net/ethernet/intel/iavf/iavf_txrx.c | 433 ++++++++++++---- drivers/net/ethernet/intel/iavf/iavf_txrx.h | 24 +- drivers/net/ethernet/intel/iavf/iavf_type.h | 239 ++++----- drivers/net/ethernet/intel/iavf/iavf_types.h | 34 ++ .../net/ethernet/intel/iavf/iavf_virtchnl.c | 203 ++++++++ drivers/net/ethernet/intel/ice/ice_base.c | 3 - drivers/net/ethernet/intel/ice/ice_lib.c | 5 +- drivers/net/ethernet/intel/ice/ice_ptp.c | 4 +- drivers/net/ethernet/intel/ice/ice_ptp.h | 8 + drivers/net/ethernet/intel/ice/ice_vf_lib.h | 3 + drivers/net/ethernet/intel/ice/ice_virtchnl.c | 77 ++- drivers/net/ethernet/intel/ice/ice_virtchnl.h | 6 + .../intel/ice/ice_virtchnl_allowlist.c | 7 + .../ethernet/intel/idpf/idpf_singleq_txrx.c | 51 +- drivers/net/ethernet/intel/idpf/idpf_txrx.c | 16 +- drivers/net/ethernet/intel/idpf/idpf_txrx.h | 19 - include/linux/avf/virtchnl.h | 135 ++++- include/net/libeth/rx.h | 47 ++ 25 files changed, 1787 insertions(+), 331 deletions(-) create mode 100644 drivers/net/ethernet/intel/iavf/iavf_ptp.c create mode 100644 drivers/net/ethernet/intel/iavf/iavf_ptp.h create mode 100644 drivers/net/ethernet/intel/iavf/iavf_types.h base-commit: 2c2b80f0ad2ff47a6e56baad9381442e5dae3054