From patchwork Fri Nov 8 06:14:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Namhyung Kim X-Patchwork-Id: 13867601 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4EB81D0146; Fri, 8 Nov 2024 06:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731046501; cv=none; b=H8ED5vOTt7ZU273r44uX+667dOz6FhnEGxf3er+EbXwrqNFhOn4+sDdISKAzAot9f+zjyUqxL/ZKXZUAIfWxfYwUngLSXefVjTHgd6Qwu2uPG0nveeucokbdTH7r5+XQ73QxA2hJWGbVGnBrW0prosuCVrcD1ZfyT+Gu7icraLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731046501; c=relaxed/simple; bh=eUXmnG82VK1Ao9xpUP1276Kus2acS1r2yCCwIcj0U+E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XMSrurb78mE7gzRqzTFVB5v2pYmMOcUvTfXFAY2PJ0Sh25JGK+mwWfzgvjioZyN550CWk81sUSKpz3+umpSnuhAh65tJwhXSJQMzI0/nmGPRo/KMNIPXeUuJHpJJ81MiziDR8uqh41Pq2B75zRljmcUXZGeh4A5ucmlaP6Y4EHo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qcpaop2v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qcpaop2v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB7A1C4CECE; Fri, 8 Nov 2024 06:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731046501; bh=eUXmnG82VK1Ao9xpUP1276Kus2acS1r2yCCwIcj0U+E=; h=From:To:Cc:Subject:Date:From; b=qcpaop2vlOf+Mf6MiI0DTcS7oNOTEhJ6BJlHAQx369kVmkDgLBI8kEprmVFj2EKbM WRaPkQfxhxTHcBbXXb0xcg9riLSr8/mOKrJ7rH9IJh+/aR8s7HBMgx9pz4w6jwg+QT HCK7ALJIX2lKdVtp5/4eA0yykQNmlcLp4V3mvF0MvwqBYDCOarj+zS5jpn7y4ZSSyT 7GobeXv13yHA8bcwF9vwZiRzYO7B6tlCZyicNKw2ZDuMe+LxlxD5VM9Yx98i7PD9AC gC6bCiQbSA3pvrChpRsi6b/ksh9HsqLDhamBzKUn0WCu+RRPlkeQM5oLyVGZy9PnG3 hk3A45QAg9YqA== From: Namhyung Kim To: Arnaldo Carvalho de Melo , Ian Rogers , Kan Liang Cc: Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Andrii Nakryiko , Song Liu , bpf@vger.kernel.org, Stephane Eranian , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook Subject: [PATCH v2 0/4] perf lock contention: Symbolize locks using slab cache names Date: Thu, 7 Nov 2024 22:14:55 -0800 Message-ID: <20241108061500.2698340-1-namhyung@kernel.org> X-Mailer: git-send-email 2.47.0.277.g8800431eea-goog Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, This is to support symbolization of dynamic locks using slab allocator's metadata. The kernel support is in the bpf-next tree now. It provides the new "kmem_cache" BPF iterator and "bpf_get_kmem_cache" kfunc to get the information from an address. The feature detection is done using BTF type info and it won't have any effect on old kernels. v2 changes) * don't use libbpf_get_error() (Andrii) v1) https://lore.kernel.org/linux-perf-users/20241105172635.2463800-1-namhyung@kernel.org With this change, it can show locks in a slab object like below. I added "&" sign to distinguish them from global locks. # perf lock con -abl sleep 1 contended total wait max wait avg wait address symbol 2 1.95 us 1.77 us 975 ns ffff9d5e852d3498 &task_struct (mutex) 1 1.18 us 1.18 us 1.18 us ffff9d5e852d3538 &task_struct (mutex) 4 1.12 us 354 ns 279 ns ffff9d5e841ca800 &kmalloc-cg-512 (mutex) 2 859 ns 617 ns 429 ns ffffffffa41c3620 delayed_uprobe_lock (mutex) 3 691 ns 388 ns 230 ns ffffffffa41c0940 pack_mutex (mutex) 3 421 ns 164 ns 140 ns ffffffffa3a8b3a0 text_mutex (mutex) 1 409 ns 409 ns 409 ns ffffffffa41b4cf8 tracepoint_srcu_srcu_usage (mutex) 2 362 ns 239 ns 181 ns ffffffffa41cf840 pcpu_alloc_mutex (mutex) 1 220 ns 220 ns 220 ns ffff9d5e82b534d8 &signal_cache (mutex) 1 215 ns 215 ns 215 ns ffffffffa41b4c28 tracepoint_srcu_srcu_usage (mutex) The first two were from "task_struct" slab cache. It happened to match with the type name of object but there's no guarantee. We need to add type info to slab cache to resolve the lock inside the object. Anyway, the third one has no dedicated slab cache and was allocated by kmalloc. Those slab objects can be used to filter specific locks using -L or --lock-filter option. (It needs quotes to avoid special handling in the shell). # perf lock con -ab -L '&task_struct' sleep 1 contended total wait max wait avg wait type caller 1 25.10 us 25.10 us 25.10 us mutex perf_event_exit_task+0x39 1 21.60 us 21.60 us 21.60 us mutex futex_exit_release+0x21 1 5.56 us 5.56 us 5.56 us mutex futex_exec_release+0x21 The code is available at 'perf/lock-slab-v2' branch in my tree git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git Thanks, Namhyung Namhyung Kim (4): perf lock contention: Add and use LCB_F_TYPE_MASK perf lock contention: Run BPF slab cache iterator perf lock contention: Resolve slab object name using BPF perf lock contention: Handle slab objects in -L/--lock-filter option tools/perf/builtin-lock.c | 39 ++++- tools/perf/util/bpf_lock_contention.c | 140 +++++++++++++++++- .../perf/util/bpf_skel/lock_contention.bpf.c | 70 ++++++++- tools/perf/util/bpf_skel/lock_data.h | 15 +- tools/perf/util/bpf_skel/vmlinux/vmlinux.h | 8 + tools/perf/util/lock-contention.h | 2 + 6 files changed, 267 insertions(+), 7 deletions(-)