| Message ID | 20241111-tcan-wkrqv-v2-0-9763519b5252@geanix.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | can: tcan4x5x: add option for selecting nWKRQ voltage | expand |
On Mon, 11 Nov 2024 09:54:48 +0100 Sean Nyekjaer wrote:
> This series adds support for setting the nWKRQ voltage.
There is no need to CC netdev@ on pure drivers/net/can changes.
Since these changes are not tagged in any way I have to manually
go and drop all of them from our patchwork.
Hi Jakub, On Mon, Nov 11, 2024 at 10:10:11AM +0100, Jakub Kicinski wrote: > On Mon, 11 Nov 2024 09:54:48 +0100 Sean Nyekjaer wrote: > > This series adds support for setting the nWKRQ voltage. > > There is no need to CC netdev@ on pure drivers/net/can changes. > Since these changes are not tagged in any way I have to manually > go and drop all of them from our patchwork. Oh sorry for that. I'm using b4's --auto-to-cc feature, any way to fix that? Br, /Sean
On 12.11.2024 07:39:12, Sean Nyekjaer wrote: > On Mon, Nov 11, 2024 at 10:10:11AM +0100, Jakub Kicinski wrote: > > On Mon, 11 Nov 2024 09:54:48 +0100 Sean Nyekjaer wrote: > > > This series adds support for setting the nWKRQ voltage. > > > > There is no need to CC netdev@ on pure drivers/net/can changes. > > Since these changes are not tagged in any way I have to manually > > go and drop all of them from our patchwork. Does the prefix "can-next" help, i.e.: | [PATCH can-next v2 0/2] which can be configured via: | b4 prep --set-prefixes "can-next" > Oh sorry for that. > I'm using b4's --auto-to-cc feature, any way to fix that? You can manually trim the list of Cc: using: | b4 prep --edit-cover regards, Marc
On 11.11.2024 09:54:48, Sean Nyekjaer wrote:
> This series adds support for setting the nWKRQ voltage.
IIRC the yaml change should be made before the driver change. Please
make the yaml changes the 1st patch in the series.
Marc
Hi Marc, On Tue, Nov 12, 2024 at 08:38:26AM +0100, Marc Kleine-Budde wrote: > On 11.11.2024 09:54:48, Sean Nyekjaer wrote: > > This series adds support for setting the nWKRQ voltage. > > IIRC the yaml change should be made before the driver change. Please > make the yaml changes the 1st patch in the series. > > Marc > I know, so I have added, prerequisite-change-id as pr the b4 manual. /Sean
On 12.11.2024 08:44:00, Sean Nyekjaer wrote: > Hi Marc, > > On Tue, Nov 12, 2024 at 08:38:26AM +0100, Marc Kleine-Budde wrote: > > On 11.11.2024 09:54:48, Sean Nyekjaer wrote: > > > This series adds support for setting the nWKRQ voltage. > > > > IIRC the yaml change should be made before the driver change. Please > > make the yaml changes the 1st patch in the series. > > > > Marc > > > > I know, so I have added, prerequisite-change-id as pr the b4 manual. I mean the order of patches in this series. First the yaml patch, then the code change. regards, Marc
Hi Marc, On Tue, Nov 12, 2024 at 08:52:14AM +0100, Marc Kleine-Budde wrote: > On 12.11.2024 08:44:00, Sean Nyekjaer wrote: > > Hi Marc, > > > > On Tue, Nov 12, 2024 at 08:38:26AM +0100, Marc Kleine-Budde wrote: > > > On 11.11.2024 09:54:48, Sean Nyekjaer wrote: > > > > This series adds support for setting the nWKRQ voltage. > > > > > > IIRC the yaml change should be made before the driver change. Please > > > make the yaml changes the 1st patch in the series. > > > > > > Marc > > > > > > > I know, so I have added, prerequisite-change-id as pr the b4 manual. > > I mean the order of patches in this series. First the yaml patch, then > the code change. > > regards, > Marc > Oh, noted thanks! /Sean
On Tue, 12 Nov 2024 08:16:02 +0100 Marc Kleine-Budde wrote: > > > There is no need to CC netdev@ on pure drivers/net/can changes. > > > Since these changes are not tagged in any way I have to manually > > > go and drop all of them from our patchwork. > > Does the prefix "can-next" help, i.e.: > > | [PATCH can-next v2 0/2] > > which can be configured via: > > | b4 prep --set-prefixes "can-next" Yup, prefix would make it easy for us to automatically discard ! > > Oh sorry for that. > > I'm using b4's --auto-to-cc feature, any way to fix that? > > You can manually trim the list of Cc: using: > > | b4 prep --edit-cover My bad actually, I didn't realize we don't have an X: entries on net/can/ under general networking in MAINTAINERS. Would you mind if I added them?
On Thu. 14 Nov. 2024 at 12:37, Jakub Kicinski <kuba@kernel.org> wrote: > My bad actually, I didn't realize we don't have an X: entries > on net/can/ under general networking in MAINTAINERS. > > Would you mind if I added them? OK for me. I guess you want to add the exclusion for both the CAN NETWORK DRIVERS and the CAN NETWORK LAYER entries in MAINTAINERS. Yours sincerely, Vincent Mailhol
On 13.11.2024 19:37:09, Jakub Kicinski wrote: > On Tue, 12 Nov 2024 08:16:02 +0100 Marc Kleine-Budde wrote: > > > > There is no need to CC netdev@ on pure drivers/net/can changes. > > > > Since these changes are not tagged in any way I have to manually > > > > go and drop all of them from our patchwork. > > > > Does the prefix "can-next" help, i.e.: > > > > | [PATCH can-next v2 0/2] > > > > which can be configured via: > > > > | b4 prep --set-prefixes "can-next" > > Yup, prefix would make it easy for us to automatically discard ! > > > > Oh sorry for that. > > > I'm using b4's --auto-to-cc feature, any way to fix that? > > > > You can manually trim the list of Cc: using: > > > > | b4 prep --edit-cover > > My bad actually, I didn't realize we don't have an X: entries > on net/can/ under general networking in MAINTAINERS. > > Would you mind if I added them? Makes sense! I didn'k know that X: exists and that it makes total sense here. Feel free to add my: Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Marc
On 14.11.2024 13:41:12, Vincent Mailhol wrote: > On Thu. 14 Nov. 2024 at 12:37, Jakub Kicinski <kuba@kernel.org> wrote: > > My bad actually, I didn't realize we don't have an X: entries > > on net/can/ under general networking in MAINTAINERS. ^^^^^^^^^^^^^^^^^^ > > > > Would you mind if I added them? > > OK for me. I guess you want to add the exclusion for both the > > CAN NETWORK DRIVERS > > and the > > CAN NETWORK LAYER > > entries in MAINTAINERS. I thinks, it's the other way round. General networking gets an X: for driver/net/can and driver/can/ and the include files. Marc
On 14/11/2024 at 18:03, Marc Kleine-Budde wrote: > On 14.11.2024 13:41:12, Vincent Mailhol wrote: >> On Thu. 14 Nov. 2024 at 12:37, Jakub Kicinski <kuba@kernel.org> wrote: >>> My bad actually, I didn't realize we don't have an X: entries >>> on net/can/ under general networking in MAINTAINERS. > ^^^^^^^^^^^^^^^^^^ >>> >>> Would you mind if I added them? >> >> OK for me. I guess you want to add the exclusion for both the >> >> CAN NETWORK DRIVERS >> >> and the >> >> CAN NETWORK LAYER >> >> entries in MAINTAINERS. > > I thinks, it's the other way round. > > General networking gets an X: for driver/net/can and driver/can/ and the > include files. Indeed. Now that you say it, makes perfect sense. @Jakub, similar to Marc, feel free to add my Acked-by tag when you send such a patch. Yours sincerely, Vincent Mailhol
This series adds support for setting the nWKRQ voltage. Signed-off-by: Sean Nyekjaer <sean@geanix.com> --- Changes in v2: - Converted tcan4x5x.txt to DT schema. In https://lore.kernel.org/linux-can/20241105-convert-tcan-v2-1-4b320f3fcf99@geanix.com/ - Reworked ti,nwkrq-voltage-sel, to DH schema style. - Link to v1: https://lore.kernel.org/r/20241031-tcan-wkrqv-v1-0-823dbd12fe4a@geanix.com --- Sean Nyekjaer (2): can: tcan4x5x: add option for selecting nWKRQ voltage dt-bindings: can: tcan4x5x: Document the ti,nwkrq-voltage-sel option .../devicetree/bindings/net/can/ti,tcan4x5x.yaml | 13 ++++++++ drivers/net/can/m_can/tcan4x5x-core.c | 35 ++++++++++++++++++++++ drivers/net/can/m_can/tcan4x5x.h | 2 ++ 3 files changed, 50 insertions(+) --- base-commit: 2b2a9a08f8f0b904ea2bc61db3374421b0f944a6 change-id: 20241030-tcan-wkrqv-c62b906005da prerequisite-change-id: 20241105-convert-tcan-4b516424ecf6:v2 prerequisite-patch-id: a652b1a16dadd5ff525d0b58fec56f605a976aa3 Best regards,