[v2,net,0/4] net: dsa: mv88e6xxx: Amethyst (6393X) fixes

Message

Tobias Waldekranz Dec. 19, 2024, 12:30 p.m. UTC

This series provides a set of bug fixes discovered while bringing up a
new board using mv88e6393x chips.

1/4 adds logging of low-level I/O errors that where previously only
logged at a much higher layer, e.g. "probe failed" or "failed to add
VLAN", at which time the origin of the error was long gone. Not
exactly a bugfix, though still suitable for -net IMHO; but I'm also
happy to send it via net-next instead if that makes more sense.

2/4 fixes an issue I've never seen on any other board. At first I
assumed that there was some board-specific issue, but we've not been
able to find one. If you give the chip enough time, it will eventually
signal "PPU Polling" and everything else will work as
expected. Therefore I assume that all is in order, and that we simply
need to increase the timeout.

3/4 just broadens Chris' original fix to apply to all chips. Though I
have obviously not tested this on every supported device, I can't see
how this could possibly be chip specific. Was there some specific
reason for originally limiting the set of chips that this applied to?

4/4 can only be supported on the Amethyst, which can control the
ieee-multicast policy per-port, rather than via a global setting as
it's done on the older families.

v1 -> v2:
 - Increase the global timeout in mv88e6xxx_wait_mask() to cover the
   slow PPU init, rather handling PPU init as a special case (Andrew)
 - (Because of the previous change, Paolo's suggestion on lowering the
   priority of the log message was rendered mute)

Tobias Waldekranz (4):
  net: dsa: mv88e6xxx: Improve I/O related error logging
  net: dsa: mv88e6xxx: Give chips more time to activate their PPUs
  net: dsa: mv88e6xxx: Never force link on in-band managed MACs
  net: dsa: mv88e6xxx: Limit rsvd2cpu policy to user ports on 6393X

 drivers/net/dsa/mv88e6xxx/chip.c | 88 +++++++++++++++++---------------
 drivers/net/dsa/mv88e6xxx/chip.h |  4 --
 drivers/net/dsa/mv88e6xxx/port.c | 48 ++++++++---------
 drivers/net/dsa/mv88e6xxx/port.h |  1 -
 4 files changed, 72 insertions(+), 69 deletions(-)