mbox series

[net,v4,0/4] Fix race conditions in ndo_get_stats64

Message ID 20250102112246.2494230-1-srasheed@marvell.com (mailing list archive)
Headers show
Series Fix race conditions in ndo_get_stats64 | expand

Message

Shinas Rasheed Jan. 2, 2025, 11:22 a.m. UTC
Fix race conditions in ndo_get_stats64 by checking if netdev is running
before per queue resources are accessed, and remove stats fetch from
firmware which is currently unnecessary

Changes:
V4:
  - Check if netdev is running, as decision for accessing resources
    rather than availing lock implementations, in ndo_get_stats64()

V3: https://lore.kernel.org/all/20241218115111.2407958-1-srasheed@marvell.com/
  - Added warn log that happened due to rcu_read_lock in commit message

V2: https://lore.kernel.org/all/20241216075842.2394606-1-srasheed@marvell.com/
  - Changed sync mechanism to fix race conditions from using an atomic
    set_bit ops to a much simpler synchronize_net()

V1: https://lore.kernel.org/all/20241203072130.2316913-1-srasheed@marvell.com/

Shinas Rasheed (4):
  octeon_ep: fix race conditions in ndo_get_stats64
  octeon_ep: remove firmware stats fetch in ndo_get_stats64
  octeon_ep_vf: fix race conditions in ndo_get_stats64
  octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64

 .../net/ethernet/marvell/octeon_ep/octep_main.c    | 14 ++++----------
 .../ethernet/marvell/octeon_ep_vf/octep_vf_main.c  | 12 ++++--------
 2 files changed, 8 insertions(+), 18 deletions(-)