mbox series

[net-next,0/9] i40e deadcoding

Message ID 20250102173717.200359-1-linux@treblig.org (mailing list archive)
Headers show
Series i40e deadcoding | expand

Message

Dr. David Alan Gilbert Jan. 2, 2025, 5:37 p.m. UTC 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

Hi,
  This is a bunch of deadcoding of functions that
are entirely uncalled in the i40e driver.

  Build tested only.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
(Resend now that netdev has woken up)

Dr. David Alan Gilbert (9):
  i40e: Deadcode i40e_aq_*
  i40e: Remove unused i40e_blink_phy_link_led
  i40e: Remove unused i40e_(read|write)_phy_register
  i40e: Deadcode profile code
  i40e: Remove unused i40e_get_cur_guaranteed_fd_count
  i40e: Remove unused i40e_del_filter
  i40e: Remove unused i40e_commit_partition_bw_setting
  i40e: Remove unused i40e_asq_send_command_v2
  i40e: Remove unused i40e_dcb_hw_get_num_tc

 drivers/net/ethernet/intel/i40e/i40e.h        |   3 -
 drivers/net/ethernet/intel/i40e/i40e_adminq.c |  10 -
 drivers/net/ethernet/intel/i40e/i40e_common.c | 458 ------------------
 drivers/net/ethernet/intel/i40e/i40e_dcb.c    |  13 -
 drivers/net/ethernet/intel/i40e/i40e_dcb.h    |   1 -
 drivers/net/ethernet/intel/i40e/i40e_main.c   | 124 +----
 .../net/ethernet/intel/i40e/i40e_prototype.h  |  40 --
 7 files changed, 2 insertions(+), 647 deletions(-)

Comments

Jakub Kicinski Jan. 4, 2025, 4:16 p.m. UTC | #1 
On Thu,  2 Jan 2025 17:37:08 +0000 linux@treblig.org wrote:
>   This is a bunch of deadcoding of functions that
> are entirely uncalled in the i40e driver.
> 
>   Build tested only.

Intel folks, is it okay if we take this (and the igc series) 
in directly? Seems very unlikely to require testing...
Tony Nguyen Jan. 6, 2025, 6:36 p.m. UTC | #2 
On 1/4/2025 8:16 AM, Jakub Kicinski wrote:
> On Thu,  2 Jan 2025 17:37:08 +0000 linux@treblig.org wrote:
>>    This is a bunch of deadcoding of functions that
>> are entirely uncalled in the i40e driver.
>>
>>    Build tested only.
> 
> Intel folks, is it okay if we take this (and the igc series)
> in directly? Seems very unlikely to require testing...

It's fine to take directly. I don't think this needs testing either.

I believe this will get picked up from here:
Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>

Thanks,
Tony
patchwork-bot+netdevbpf@kernel.org Jan. 6, 2025, 9:50 p.m. UTC | #3 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  2 Jan 2025 17:37:08 +0000 you wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> Hi,
>   This is a bunch of deadcoding of functions that
> are entirely uncalled in the i40e driver.
> 
>   Build tested only.
> 
> [...]

Here is the summary with links:
  - [net-next,1/9] i40e: Deadcode i40e_aq_*
    https://git.kernel.org/netdev/net-next/c/59ec698d01eb
  - [net-next,2/9] i40e: Remove unused i40e_blink_phy_link_led
    https://git.kernel.org/netdev/net-next/c/39cabb01d26d
  - [net-next,3/9] i40e: Remove unused i40e_(read|write)_phy_register
    https://git.kernel.org/netdev/net-next/c/8cc51e28ecce
  - [net-next,4/9] i40e: Deadcode profile code
    https://git.kernel.org/netdev/net-next/c/81d6bb2012e1
  - [net-next,5/9] i40e: Remove unused i40e_get_cur_guaranteed_fd_count
    https://git.kernel.org/netdev/net-next/c/3eb24a9e0af3
  - [net-next,6/9] i40e: Remove unused i40e_del_filter
    https://git.kernel.org/netdev/net-next/c/38dfb07d9a65
  - [net-next,7/9] i40e: Remove unused i40e_commit_partition_bw_setting
    https://git.kernel.org/netdev/net-next/c/a324484ac855
  - [net-next,8/9] i40e: Remove unused i40e_asq_send_command_v2
    https://git.kernel.org/netdev/net-next/c/d424b93f35a6
  - [net-next,9/9] i40e: Remove unused i40e_dcb_hw_get_num_tc
    https://git.kernel.org/netdev/net-next/c/47ea5d4e6f40

You are awesome, thank you!