[net-next,00/15,pull,request] Intel Wired LAN Driver Updates 2025-01-06 (igb, igc, ixgbe, ixgbevf, i40e, fm10k)

Message

Tony Nguyen Jan. 6, 2025, 10:19 p.m. UTC

For igb:

Sriram Yagnaraman and Kurt Kanzenbach add support for AF_XDP
zero-copy.

Original cover letter:
The first couple of patches adds helper functions to prepare for AF_XDP
zero-copy support which comes in the last couple of patches, one each
for Rx and TX paths.

As mentioned in v1 patchset [0], I don't have access to an actual IGB
device to provide correct performance numbers. I have used Intel 82576EB
emulator in QEMU [1] to test the changes to IGB driver.

The tests use one isolated vCPU for RX/TX and one isolated vCPU for the
xdp-sock application [2]. Hope these measurements provide at the least
some indication on the increase in performance when using ZC, especially
in the TX path. It would be awesome if someone with a real IGB NIC can
test the patch.

AF_XDP performance using 64 byte packets in Kpps.
Benchmark:	XDP-SKB		XDP-DRV		XDP-DRV(ZC)
rxdrop		220		235		350
txpush		1.000		1.000		410
l2fwd 		1.000		1.000		200

AF_XDP performance using 1500 byte packets in Kpps.
Benchmark:	XDP-SKB		XDP-DRV		XDP-DRV(ZC)
rxdrop		200		210		310
txpush		1.000		1.000		410
l2fwd 		0.900		1.000		160

[0]: https://lore.kernel.org/intel-wired-lan/[e-mail]/
[1]: https://www.qemu.org/docs/master/system/devices/igb.html
[2]: https://github.com/xdp-project/bpf-examples/tree/master/AF_XDP-example

Subsequent changes and information can be found here:
https://lore.kernel.org/intel-wired-lan/[e-mail]/

Yue Haibing converts use of ERR_PTR return to traditional error code
which resolves a smatch warning.

For igc:

Song Yoong Siang allows for the XDP program to be hot-swapped.

Yue Haibing converts use of ERR_PTR return to traditional error code
which resolves a smatch warning.

Joe Damato adds sets IRQ and queues to NAPI instances to allow for
reporting via netdev-genl API.

For ixgbe:

Yue Haibing converts use of ERR_PTR return to traditional error code
which resolves a smatch warning.

For ixgbevf:

Yue Haibing converts use of ERR_PTR return to traditional error code
which resolves a smatch warning.

For i40e:

Alex implements "mdd-auto-reset-vf" private flag to automatically reset
VFs when encountering an MDD event.

For fm10k:

Dr. David Alan Gilbert removes an unused function.

The following are changes since commit 3e5908172c05ab1511f2a6719b806d6eda6e1715:
  Merge tag 'ieee802154-for-net-next-2025-01-03' of git://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan-next
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 1GbE

Aleksandr Loktionov (1):
  i40e: add ability to reset VF for Tx and Rx MDD events

Dr. David Alan Gilbert (1):
  intel/fm10k: Remove unused fm10k_iov_msg_mac_vlan_pf

Joe Damato (2):
  igc: Link IRQs to NAPI instances
  igc: Link queues to NAPI instances

Kurt Kanzenbach (1):
  igb: Add XDP finalize and stats update functions

Song Yoong Siang (1):
  igc: Allow hot-swapping XDP program

Sriram Yagnaraman (5):
  igb: Remove static qualifiers
  igb: Introduce igb_xdp_is_enabled()
  igb: Introduce XSK data structures and helpers
  igb: Add AF_XDP zero-copy Rx support
  igb: Add AF_XDP zero-copy Tx support

Yue Haibing (4):
  igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()
  igb: Fix passing 0 to ERR_PTR in igb_run_xdp()
  ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()
  ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()

 .../device_drivers/ethernet/intel/i40e.rst    |  12 +
 drivers/net/ethernet/intel/fm10k/fm10k_pf.c   | 120 ----
 drivers/net/ethernet/intel/fm10k/fm10k_pf.h   |   2 -
 drivers/net/ethernet/intel/i40e/i40e.h        |   4 +-
 .../net/ethernet/intel/i40e/i40e_debugfs.c    |   2 +-
 .../net/ethernet/intel/i40e/i40e_ethtool.c    |   2 +
 drivers/net/ethernet/intel/i40e/i40e_main.c   | 107 +++-
 .../ethernet/intel/i40e/i40e_virtchnl_pf.c    |   2 +-
 .../ethernet/intel/i40e/i40e_virtchnl_pf.h    |  11 +-
 drivers/net/ethernet/intel/igb/Makefile       |   2 +-
 drivers/net/ethernet/intel/igb/igb.h          |  58 +-
 drivers/net/ethernet/intel/igb/igb_main.c     | 270 ++++++---
 drivers/net/ethernet/intel/igb/igb_xsk.c      | 562 ++++++++++++++++++
 drivers/net/ethernet/intel/igc/igc.h          |   2 +
 drivers/net/ethernet/intel/igc/igc_main.c     |  79 ++-
 drivers/net/ethernet/intel/igc/igc_xdp.c      |   8 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  23 +-
 .../net/ethernet/intel/ixgbevf/ixgbevf_main.c |  23 +-
 18 files changed, 1002 insertions(+), 287 deletions(-)
 create mode 100644 drivers/net/ethernet/intel/igb/igb_xsk.c

Comments

Jakub Kicinski Jan. 8, 2025, 2:13 a.m. UTC | #1

On Mon,  6 Jan 2025 14:19:08 -0800 Tony Nguyen wrote:
> Yue Haibing (4):
>   igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()
>   igb: Fix passing 0 to ERR_PTR in igb_run_xdp()
>   ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()
>   ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()

I'm going to apply from the list, these don't need a fixes tag.

[e-mail] Jan. 8, 2025, 2:30 a.m. UTC | #2

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Mon,  6 Jan 2025 14:19:08 -0800 you wrote:
> For igb:
> 
> Sriram Yagnaraman and Kurt Kanzenbach add support for AF_XDP
> zero-copy.
> 
> Original cover letter:
> The first couple of patches adds helper functions to prepare for AF_XDP
> zero-copy support which comes in the last couple of patches, one each
> for Rx and TX paths.
> 
> [...]

Here is the summary with links:
  - [net-next,01/15] igb: Remove static qualifiers
    https://git.kernel.org/netdev/net-next/c/f70b864ccc84
  - [net-next,02/15] igb: Introduce igb_xdp_is_enabled()
    https://git.kernel.org/netdev/net-next/c/6dc75fc230ec
  - [net-next,03/15] igb: Introduce XSK data structures and helpers
    https://git.kernel.org/netdev/net-next/c/80f6ccf9f116
  - [net-next,04/15] igb: Add XDP finalize and stats update functions
    https://git.kernel.org/netdev/net-next/c/0fe7cce6000c
  - [net-next,05/15] igb: Add AF_XDP zero-copy Rx support
    https://git.kernel.org/netdev/net-next/c/2c6196013f84
  - [net-next,06/15] igb: Add AF_XDP zero-copy Tx support
    https://git.kernel.org/netdev/net-next/c/f8e284a02afc
  - [net-next,07/15] igc: Allow hot-swapping XDP program
    https://git.kernel.org/netdev/net-next/c/484d3675f2aa
  - [net-next,08/15] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()
    https://git.kernel.org/netdev/net-next/c/8b6237e1f4d4
  - [net-next,09/15] igb: Fix passing 0 to ERR_PTR in igb_run_xdp()
    https://git.kernel.org/netdev/net-next/c/8ae94669b1f3
  - [net-next,10/15] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()
    https://git.kernel.org/netdev/net-next/c/c824125cbb18
  - [net-next,11/15] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()
    https://git.kernel.org/netdev/net-next/c/35f715cb77c3
  - [net-next,12/15] i40e: add ability to reset VF for Tx and Rx MDD events
    https://git.kernel.org/netdev/net-next/c/07af482e6465
  - [net-next,13/15] igc: Link IRQs to NAPI instances
    https://git.kernel.org/netdev/net-next/c/1a63399c13fe
  - [net-next,14/15] igc: Link queues to NAPI instances
    https://git.kernel.org/netdev/net-next/c/b65969856d4f
  - [net-next,15/15] intel/fm10k: Remove unused fm10k_iov_msg_mac_vlan_pf
    https://git.kernel.org/netdev/net-next/c/605237372a53

You are awesome, thank you!

Tony Nguyen Jan. 8, 2025, 7:01 p.m. UTC | #3

On 1/7/2025 6:13 PM, Jakub Kicinski wrote:
> On Mon,  6 Jan 2025 14:19:08 -0800 Tony Nguyen wrote:
>> Yue Haibing (4):
>>    igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()
>>    igb: Fix passing 0 to ERR_PTR in igb_run_xdp()
>>    ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()
>>    ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()
> 
> I'm going to apply from the list, these don't need a fixes tag.

Thank you.

- Tony