| Message ID | 20250113-net-mptcp-connect-st-flakes-v1-0-0d986ee7b1b6@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: fixes for connect selftest flakes | expand |
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 13 Jan 2025 16:44:55 +0100 you wrote: > Last week, Jakub reported [1] that the MPTCP Connect selftest was > unstable. It looked like it started after the introduction of some fixes > [2]. After analysis from Paolo, these patches revealed existing bugs, > that should be fixed by the following patches. > > - Patch 1: Make sure ACK are sent when MPTCP-level window re-opens. In > some corner cases, the other peer was not notified when more data > could be sent. A fix for v5.11, but depending on a feature introduced > in v5.19. > > [...] Here is the summary with links: - [net,1/3] mptcp: be sure to send ack when mptcp-level window re-opens https://git.kernel.org/netdev/net/c/2ca06a2f6531 - [net,2/3] mptcp: fix spurious wake-up on under memory pressure https://git.kernel.org/netdev/net/c/e226d9259dc4 - [net,3/3] selftests: mptcp: avoid spurious errors on disconnect https://git.kernel.org/netdev/net/c/218cc166321f You are awesome, thank you!
Last week, Jakub reported [1] that the MPTCP Connect selftest was unstable. It looked like it started after the introduction of some fixes [2]. After analysis from Paolo, these patches revealed existing bugs, that should be fixed by the following patches. - Patch 1: Make sure ACK are sent when MPTCP-level window re-opens. In some corner cases, the other peer was not notified when more data could be sent. A fix for v5.11, but depending on a feature introduced in v5.19. - Patch 2: Fix spurious wake-up under memory pressure. In this situation, the userspace could be invited to read data not being there yet. A fix for v6.7. - Patch 3: Fix a false positive error when running the MPTCP Connect selftest with the "disconnect" cases. The userspace could disconnect the socket too soon, which would reset (MP_FASTCLOSE) the connection, interpreted as an error by the test. A fix for v5.17. Link: https://lore.kernel.org/20250107131845.5e5de3c5@kernel.org [1] Link: https://lore.kernel.org/20241230-net-mptcp-rbuf-fixes-v1-0-8608af434ceb@kernel.org [2] Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Paolo Abeni (3): mptcp: be sure to send ack when mptcp-level window re-opens mptcp: fix spurious wake-up on under memory pressure selftests: mptcp: avoid spurious errors on disconnect net/mptcp/options.c | 6 ++-- net/mptcp/protocol.h | 9 +++-- tools/testing/selftests/net/mptcp/mptcp_connect.c | 43 +++++++++++++++++------ 3 files changed, 43 insertions(+), 15 deletions(-) --- base-commit: 76201b5979768500bca362871db66d77cb4c225e change-id: 20250113-net-mptcp-connect-st-flakes-4af6389808de Best regards,