mbox series

[net,v2,0/4,pull,request] Fix E825 initialization

Message ID 20250113182840.3564250-1-anthony.l.nguyen@intel.com (mailing list archive)
Headers show
Series Fix E825 initialization | expand

Message

Tony Nguyen Jan. 13, 2025, 6:28 p.m. UTC 
Grzegorz Nitka says:

E825 products have incorrect initialization procedure, which may lead to
initialization failures and register values.

Fix E825 products initialization by adding correct sync delay, checking
the PHY revision only for current PHY and adding proper destination
device when reading port/quad.

In addition, E825 uses PF ID for indexing per PF registers and as
a primary PHY lane number, which is incorrect.
---
v1: https://lore.kernel.org/netdev/20241206193542.4121545-1-anthony.l.nguyen@intel.com/
- Remove a few cosmetic changes (Patch 2)
- Remove use of __kfree() (Patch 4)

IWL: https://lore.kernel.org/intel-wired-lan/20241105122916.1824568-1-grzegorz.nitka@intel.com/

The following are changes since commit 76201b5979768500bca362871db66d77cb4c225e:
  pktgen: Avoid out-of-bounds access in get_imix_entries
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 100GbE

Karol Kolacinski (4):
  ice: Fix E825 initialization
  ice: Fix quad registers read on E825
  ice: Fix ETH56G FC-FEC Rx offset value
  ice: Add correct PHY lane assignment

 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   1 +
 drivers/net/ethernet/intel/ice/ice_common.c   |  51 ++++
 drivers/net/ethernet/intel/ice/ice_common.h   |   1 +
 drivers/net/ethernet/intel/ice/ice_main.c     |   6 +-
 drivers/net/ethernet/intel/ice/ice_ptp.c      |  23 +-
 drivers/net/ethernet/intel/ice/ice_ptp.h      |   4 +-
 .../net/ethernet/intel/ice/ice_ptp_consts.h   |   2 +-
 drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 263 ++++++++++--------
 drivers/net/ethernet/intel/ice/ice_type.h     |   2 -
 9 files changed, 209 insertions(+), 144 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 14, 2025, 9:50 p.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by Tony Nguyen <anthony.l.nguyen@intel.com>:

On Mon, 13 Jan 2025 10:28:32 -0800 you wrote:
> Grzegorz Nitka says:
> 
> E825 products have incorrect initialization procedure, which may lead to
> initialization failures and register values.
> 
> Fix E825 products initialization by adding correct sync delay, checking
> the PHY revision only for current PHY and adding proper destination
> device when reading port/quad.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/4] ice: Fix E825 initialization
    https://git.kernel.org/netdev/net/c/d79c304c76e9
  - [net,v2,2/4] ice: Fix quad registers read on E825
    https://git.kernel.org/netdev/net/c/dc26548d729e
  - [net,v2,3/4] ice: Fix ETH56G FC-FEC Rx offset value
    https://git.kernel.org/netdev/net/c/2e60560f1ec9
  - [net,v2,4/4] ice: Add correct PHY lane assignment
    https://git.kernel.org/netdev/net/c/258f5f905815

You are awesome, thank you!