[v5,net-next,0/5] PHC support in ENA driver

Message

Arinzon, David Jan. 22, 2025, 10:20 a.m. UTC

Changes in v5:
- Add PHC error bound
- Add PHC enablement and error bound retrieval through sysfs

Changes in v4:
- Minor documentation change (resolution instead of accuracy)

Changes in v3:
- Resolve a compilation error

Changes in v2:
- CCd PTP maintainer
- Fixed style issues
- Fixed documentation warning

This patchset adds the support for PHC (PTP Hardware Clock)
in the ENA driver. The documentation part of the patchset
includes additional information, including statistics,
utilization and invocation examples through the testptp
utility.

David Arinzon (5):
  net: ena: Add PHC support in the ENA driver
  net: ena: PHC silent reset
  net: ena: Add PHC documentation
  net: ena: PHC error bound/flags support
  net: ena: PHC enable and error_bound through sysfs

 .../device_drivers/ethernet/amazon/ena.rst    | 111 +++++++
 drivers/net/ethernet/amazon/Kconfig           |   1 +
 drivers/net/ethernet/amazon/ena/Makefile      |   2 +-
 .../net/ethernet/amazon/ena/ena_admin_defs.h  |  79 ++++-
 drivers/net/ethernet/amazon/ena/ena_com.c     | 276 ++++++++++++++++++
 drivers/net/ethernet/amazon/ena/ena_com.h     |  93 ++++++
 drivers/net/ethernet/amazon/ena/ena_ethtool.c | 102 +++++--
 drivers/net/ethernet/amazon/ena/ena_netdev.c  |  44 ++-
 drivers/net/ethernet/amazon/ena/ena_netdev.h  |   6 +
 drivers/net/ethernet/amazon/ena/ena_phc.c     | 239 +++++++++++++++
 drivers/net/ethernet/amazon/ena/ena_phc.h     |  38 +++
 .../net/ethernet/amazon/ena/ena_regs_defs.h   |   8 +
 drivers/net/ethernet/amazon/ena/ena_sysfs.c   | 110 +++++++
 drivers/net/ethernet/amazon/ena/ena_sysfs.h   |  28 ++
 14 files changed, 1108 insertions(+), 29 deletions(-)
 create mode 100644 drivers/net/ethernet/amazon/ena/ena_phc.c
 create mode 100644 drivers/net/ethernet/amazon/ena/ena_phc.h
 create mode 100644 drivers/net/ethernet/amazon/ena/ena_sysfs.c
 create mode 100644 drivers/net/ethernet/amazon/ena/ena_sysfs.h

Comments

Gal Pressman Jan. 22, 2025, 11:27 a.m. UTC | #1

On 22/01/2025 12:20, David Arinzon wrote:
> Changes in v5:
> - Add PHC error bound
> - Add PHC enablement and error bound retrieval through sysfs

sysfs is an interesting addition, is it a result of feedback from
previous iterations?

Arinzon, David Jan. 22, 2025, 12:13 p.m. UTC | #2

> > Changes in v5:
> > - Add PHC error bound
> > - Add PHC enablement and error bound retrieval through sysfs
> 
> sysfs is an interesting addition, is it a result of feedback from previous
> iterations?

Hi Gal,

It's not a result of feedback from previous iterations, we analyzed the
patchset (took some time to release v5) and decided that it's a mandatory addition
to this patch series.

Simon Horman Jan. 22, 2025, 1:11 p.m. UTC | #3

On Wed, Jan 22, 2025 at 12:20:35PM +0200, David Arinzon wrote:
> Changes in v5:
> - Add PHC error bound
> - Add PHC enablement and error bound retrieval through sysfs
> 
> Changes in v4:
> - Minor documentation change (resolution instead of accuracy)
> 
> Changes in v3:
> - Resolve a compilation error
> 
> Changes in v2:
> - CCd PTP maintainer
> - Fixed style issues
> - Fixed documentation warning
> 
> This patchset adds the support for PHC (PTP Hardware Clock)
> in the ENA driver. The documentation part of the patchset
> includes additional information, including statistics,
> utilization and invocation examples through the testptp
> utility.

## Form letter - net-next-closed

The merge window for v6.14 has begun. Therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after Feb 3rd.

RFC patches sent for review only are obviously welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle

--
pw-bot: deferred