[bpf-next,v7,0/6] net/smc: Introduce smc_ops

Message

D. Wythe Jan. 23, 2025, 1:59 a.m. UTC

This patch aims to introduce BPF injection capabilities for SMC and
includes a self-test to ensure code stability.

Since the SMC protocol isn't ideal for every situation, especially
short-lived ones, most applications can't guarantee the absence of
such scenarios. Consequently, applications may need specific strategies
to decide whether to use SMC. For example, an application might limit SMC
usage to certain IP addresses or ports.

To maintain the principle of transparent replacement, we want applications
to remain unaffected even if they need specific SMC strategies. In other
words, they should not require recompilation of their code.

Additionally, we need to ensure the scalability of strategy implementation.
While using socket options or sysctl might be straightforward, it could
complicate future expansions.

Fortunately, BPF addresses these concerns effectively. Users can write
their own strategies in eBPF to determine whether to use SMC, and they can
easily modify those strategies in the future.

v2:
  1. Rename smc_bpf_ops to smc_ops.
  2. Change the scope of smc_ops from global to per netns.
  3. Directly pass parameters to ops instead of smc_ops_ctx.
  4. Remove struct smc_ops_ctx.
  5. Remove exports that are no longer needed.

v3:
  1. Remove find_ksym_btf_id_by_prefix_kind.
  2. Enhance selftest, introduce a complete ops for filtering smc
     connections based on ip pairs and a realistic topology test
     to verify it.

v4:
  1. Remove unless func: smc_bpf_ops_check_member()
  2. Remove unless inline func: smc_ops_find_by_name()
  3. Change CONFIG_SMC=y to complete CI testing
  4. Change smc_sock to smc_sock___local in test to avoid
     compiling failed with CONFIG_SMC=y
  5. Improve test cases, remove unnecessary timeouts and multi-thread
     test, using network_helpers to start testing between server and
     client.
  6. Fix issues when the return value of the ops function is neither 0
     nor 1.

v5:
  1. Fix incorrect CI config from CONFIG_SMC=Y to CONFIG_SMC=y.

v6:
  1. Fix some spelling errors and code styles.
  2. Fix test failed under s390x.
  3. New approach to fix libbpf exceptions.
  4. Fix warning & failure when compiling "Introduce generic hook smc_ops".

v7:
  1. Fix some code styles.
  2. Added a fix patch for the potential UAF issue in SMC, which can occur
     easily during BPF CI tests.
  3. Fix the incorrect usage of rcu_replace_pointer and replace it with
     xhcg.
  4. Remove the forced type conversion in smc_call_retops.
  5. Use more appropriate assert macros for testing code.
  6. Remove unnecessary BPF_CORE_READ.

D. Wythe (6):
  bpf: export necessary sympols for modules with struct_ops
  net/smc: fix UAF on smcsk after smc_listen_out()
  net/smc: Introduce generic hook smc_ops
  net/smc: bpf: register smc_ops info struct_ops
  libbpf: fix error when st-prefix_ops and ops from differ btf
  bpf/selftests: add selftest for bpf_smc_ops


D. Wythe (6):
  bpf: export necessary sympols for modules with struct_ops
  net/smc: fix UAF on smcsk after smc_listen_out()
  net/smc: Introduce generic hook smc_ops
  net/smc: bpf: register smc_ops info struct_ops
  libbpf: fix error when st-prefix_ops and ops from differ btf
  bpf/selftests: add selftest for bpf_smc_ops

 include/net/netns/smc.h                       |   3 +
 include/net/smc.h                             |  53 +++
 kernel/bpf/bpf_struct_ops.c                   |   2 +
 kernel/bpf/syscall.c                          |   1 +
 net/ipv4/tcp_output.c                         |  18 +-
 net/smc/Kconfig                               |  12 +
 net/smc/Makefile                              |   1 +
 net/smc/af_smc.c                              |  14 +-
 net/smc/smc_ops.c                             | 131 ++++++
 net/smc/smc_ops.h                             |  33 ++
 net/smc/smc_sysctl.c                          |  90 ++++
 tools/lib/bpf/libbpf.c                        |  37 +-
 tools/testing/selftests/bpf/config            |   4 +
 .../selftests/bpf/prog_tests/test_bpf_smc.c   | 396 ++++++++++++++++++
 tools/testing/selftests/bpf/progs/bpf_smc.c   | 117 ++++++
 15 files changed, 888 insertions(+), 24 deletions(-)
 create mode 100644 net/smc/smc_ops.c
 create mode 100644 net/smc/smc_ops.h
 create mode 100644 tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c
 create mode 100644 tools/testing/selftests/bpf/progs/bpf_smc.c

Comments

Dust Li Jan. 23, 2025, 7:33 a.m. UTC | #1

On 2025-01-23 09:59:36, D. Wythe wrote:
>This patch aims to introduce BPF injection capabilities for SMC and
>includes a self-test to ensure code stability.
>
>Since the SMC protocol isn't ideal for every situation, especially
>short-lived ones, most applications can't guarantee the absence of
>such scenarios. Consequently, applications may need specific strategies
>to decide whether to use SMC. For example, an application might limit SMC
>usage to certain IP addresses or ports.
>
>To maintain the principle of transparent replacement, we want applications
>to remain unaffected even if they need specific SMC strategies. In other
>words, they should not require recompilation of their code.
>
>Additionally, we need to ensure the scalability of strategy implementation.
>While using socket options or sysctl might be straightforward, it could
>complicate future expansions.
>
>Fortunately, BPF addresses these concerns effectively. Users can write
>their own strategies in eBPF to determine whether to use SMC, and they can
>easily modify those strategies in the future.

The series looks good to me, except the name of smc_ops, we should come
up with a better name.

Best regards,
Dust