mbox series

[v1,0/9] Use HWMON_CHANNEL_INFO macro to simplify code

Message ID 20250124022635.16647-1-lihuisong@huawei.com (mailing list archive)
Headers show
Series Use HWMON_CHANNEL_INFO macro to simplify code | expand

Message

Huisong Li Jan. 24, 2025, 2:26 a.m. UTC 
The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many
other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code.

Huisong Li (9):
  media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code
  net: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code
  net: nfp: Use HWMON_CHANNEL_INFO macro to simplify code
  net: phy: marvell: Use HWMON_CHANNEL_INFO macro to simplify code
  net: phy: marvell10g: Use HWMON_CHANNEL_INFO macro to simplify code
  rtc: ab-eoz9: Use HWMON_CHANNEL_INFO macro to simplify code
  rtc: ds3232: Use HWMON_CHANNEL_INFO macro to simplify code
  w1: w1_therm: w1: Use HWMON_CHANNEL_INFO macro to simplify code
  net: phy: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code

 drivers/media/i2c/video-i2c.c                 | 12 +-----
 .../ethernet/aquantia/atlantic/aq_drvinfo.c   | 14 +------
 .../net/ethernet/netronome/nfp/nfp_hwmon.c    | 40 +++----------------
 drivers/net/phy/aquantia/aquantia_hwmon.c     | 32 +++------------
 drivers/net/phy/marvell.c                     | 24 +----------
 drivers/net/phy/marvell10g.c                  | 24 +----------
 drivers/rtc/rtc-ab-eoz9.c                     | 24 +----------
 drivers/rtc/rtc-ds3232.c                      | 24 +----------
 drivers/w1/slaves/w1_therm.c                  | 12 +-----
 9 files changed, 23 insertions(+), 183 deletions(-)

Comments

Andrew Lunn Jan. 24, 2025, 3:08 p.m. UTC | #1 
On Fri, Jan 24, 2025 at 10:26:26AM +0800, Huisong Li wrote:
> The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many
> other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code.
> 
> Huisong Li (9):
>   media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code
>   net: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code
>   net: nfp: Use HWMON_CHANNEL_INFO macro to simplify code
>   net: phy: marvell: Use HWMON_CHANNEL_INFO macro to simplify code
>   net: phy: marvell10g: Use HWMON_CHANNEL_INFO macro to simplify code
>   rtc: ab-eoz9: Use HWMON_CHANNEL_INFO macro to simplify code
>   rtc: ds3232: Use HWMON_CHANNEL_INFO macro to simplify code
>   w1: w1_therm: w1: Use HWMON_CHANNEL_INFO macro to simplify code
>   net: phy: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code

Please split these patches per subsystem. Maintainers generally have
scripts to accept patches, and those scripts don't work when there are
patches for other Maintainers mixed in. So you need 4 patchsets,
media, net, rtc and w1.

I would also like to see the HWMON Maintainers opinion on these. A
patchset containing these have already been NACKed once. These patches
do however look like valid cleanups. But are they just so you can do
something bad in your vendor tree, which will never make it to
mainline?

	Andrew
Guenter Roeck Jan. 24, 2025, 3:41 p.m. UTC | #2 
On 1/24/25 07:08, Andrew Lunn wrote:
> On Fri, Jan 24, 2025 at 10:26:26AM +0800, Huisong Li wrote:
>> The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many
>> other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code.
>>
>> Huisong Li (9):
>>    media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code
>>    net: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code
>>    net: nfp: Use HWMON_CHANNEL_INFO macro to simplify code
>>    net: phy: marvell: Use HWMON_CHANNEL_INFO macro to simplify code
>>    net: phy: marvell10g: Use HWMON_CHANNEL_INFO macro to simplify code
>>    rtc: ab-eoz9: Use HWMON_CHANNEL_INFO macro to simplify code
>>    rtc: ds3232: Use HWMON_CHANNEL_INFO macro to simplify code
>>    w1: w1_therm: w1: Use HWMON_CHANNEL_INFO macro to simplify code
>>    net: phy: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code
> 
> Please split these patches per subsystem. Maintainers generally have
> scripts to accept patches, and those scripts don't work when there are
> patches for other Maintainers mixed in. So you need 4 patchsets,
> media, net, rtc and w1.
> 
> I would also like to see the HWMON Maintainers opinion on these. A
> patchset containing these have already been NACKed once. These patches
> do however look like valid cleanups. But are they just so you can do
> something bad in your vendor tree, which will never make it to
> mainline?
> 

I no longer comment on hwmon related changes outside drivers/hwmon/
unless there are blatant problems such as someone trying to use an obsolete
API or abusing the current API.

Guenter
Krzysztof Kozlowski Jan. 24, 2025, 4:58 p.m. UTC | #3 
On 24/01/2025 03:26, Huisong Li wrote:
> The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many
> other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code.
> 

Read the feedback given to you last time. I do not see how you addressed
this:

"Avoid combining independent patches into one patch bomb. Or explain the
dependencies and how is it supposed to be merged - that's why you have
cover letter here."

Best regards,
Krzysztof