| Message ID | 20250129-fix_missing_rtnl_lock_phy_disconnect-v3-0-24c4ba185a92@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix missing rtnl lock in suspend path | expand |
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Wed, 29 Jan 2025 10:50:45 +0100 you wrote: > Fix the suspend path by ensuring the rtnl lock is held where required. > Calls to open, close and WOL operations must be performed under the > rtnl lock to prevent conflicts with ongoing ndo operations. > > Discussion about this issue can be found here: > https://lore.kernel.org/netdev/20250120141926.1290763-1-kory.maincent@bootlin.com/ > > [...] Here is the summary with links: - [net,v3,1/2] net: ravb: Fix missing rtnl lock in suspend/resume path https://git.kernel.org/netdev/net/c/2c2ebb2b4957 - [net,v3,2/2] net: sh_eth: Fix missing rtnl lock in suspend/resume path https://git.kernel.org/netdev/net/c/b95102215a8d You are awesome, thank you!
Fix the suspend path by ensuring the rtnl lock is held where required. Calls to open, close and WOL operations must be performed under the rtnl lock to prevent conflicts with ongoing ndo operations. Discussion about this issue can be found here: https://lore.kernel.org/netdev/20250120141926.1290763-1-kory.maincent@bootlin.com/ While working on the ravb fix, it was discovered that the sh_eth driver has the same issue. This patch series addresses both drivers. I do not have access to hardware for either of these MACs, so it would be great if maintainers or others with the relevant boards could test these fixes. Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> --- Changes in v3: - Move back to first version of ravb fix. - Remove the duplicate of the if condition in ravb fix. - Link to v2: https://lore.kernel.org/r/20250123-fix_missing_rtnl_lock_phy_disconnect-v2-0-e6206f5508ba@bootlin.com Changes in v2: - Move the rtnl_lock before ravb_wol_setup() and ravb_wol_restore() instead of before the if condition. - Link to v1: https://lore.kernel.org/r/20250122-fix_missing_rtnl_lock_phy_disconnect-v1-0-8cb9f6f88fd1@bootlin.com --- Kory Maincent (2): net: ravb: Fix missing rtnl lock in suspend/resume path net: sh_eth: Fix missing rtnl lock in suspend/resume path drivers/net/ethernet/renesas/ravb_main.c | 22 ++++++++++++++-------- drivers/net/ethernet/renesas/sh_eth.c | 4 ++++ 2 files changed, 18 insertions(+), 8 deletions(-) --- base-commit: 05d91cdb1f9108426b14975ef4eeddf15875ca05 change-id: 20250122-fix_missing_rtnl_lock_phy_disconnect-fc1d6f5db705 Best regards,