From patchwork Fri Feb 14 21:12:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Damato X-Patchwork-Id: 13975630 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FD4C1C862E for ; Fri, 14 Feb 2025 21:13:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739567591; cv=none; b=rctQ6bQN72s6KwAOViKSXP/Q2aCOD0od3LnIfs6zSAAOHqpOdvbxQlAVtl5Oy46LPIWzXep4TEpRlAWuqt77Bf68obB/9gQt9prnJARBPOKIlDsspB20i25OIDZCjXC0IVdZsDi5ikJWjc6cUzXnRhMzFfn5ay8KX3XuIagdmW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739567591; c=relaxed/simple; bh=2Z3xVZRnKUmb7k5N5LtoLiUMk2beZViDqsmP1ErC0Oo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BMP9lnfQ2qoIKrSceXxttpPpzoKS5fskjr2a4Nzs/roT9i2NZ2ImRrT8XZMLJQJd5/ewqz+4zg0PHs+U1SOa8zfxG18mSuCAZk5a3ho2H4+LDOASt6VfgJPkvkQvCBbbaO0cdY0nvBgdR3j4HkNZw9JRmeE9keXu6ZzAiF7AgDA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=rP+Va2NP; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="rP+Va2NP" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-220c92c857aso40977195ad.0 for ; Fri, 14 Feb 2025 13:13:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1739567588; x=1740172388; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KRL86cHxOa4V0i3hiENgMth/UD7EVCBFhQCErmHAqNQ=; b=rP+Va2NPA7e/sxMQovH/2vbT1BgOxov12Acb8B3PXv3sXPAGenlgCqMSt+Tqu7+22+ A5cq7Hkxh4vTMk/GRVhcPy/c5Ne8zscHalhGvch4Zm2Ccqgti30qkxxuGAnzWZZy8vBI MmSdUdc2SfLi9mXl0g0uu8bDz5Ko9LtCIixSc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739567588; x=1740172388; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KRL86cHxOa4V0i3hiENgMth/UD7EVCBFhQCErmHAqNQ=; b=aiGssmTUuPm77lrLv2Oaq7L7bL2U0v7Bt7U4ev1Aat7FV+RiaGKsIBA8zN0MX2hJQf 2EpHlR4/bxr1BHoUsydnri3dMMWjqX5qWmrL/fKsYvxFjglAQ4mjPMSMFg5YEibD2Sej CVIwyru+TfJPjktSvEHAZcaVrcmScnYkLgXJ79ctw/NF9uFBvqXi4/3bpy2JtUw0e/jn kWlP9XzyDXXvsSyh+14FClN+M4XgMJRQqiMrilQQ4/i2BKe02YZnp0ApGgTHQ4VQfjPD XyMmO/iaU0v748JJ54sbGguUU9qGxrGEYPh9Bb2x1+WsK99AYTVQcjZQDGxX/9icATWO 2u3w== X-Forwarded-Encrypted: i=1; AJvYcCUtkZJBGHRJsE0R14irIIADje+UtPyqCZ5HiTfA49azq5uOago9KS57ViV8i36vmee0lgA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx416rpK7FohHzdcLfOCNjT0L24h+xbK9tKZrIkcgaKz/JLrEYP yNcgMvyMAeL2hRupv2pYLXgNbGYBlynWvqJZwT4nX+jwL3Zeheu+x53wDgvEXoM= X-Gm-Gg: ASbGncvV4OW8+ni4KK6+zIX1FTmTXNAUMW9+dMfFRKH/1p/2hQK2uSTnv1pqARvHVgR nst4idLIUjpajIhbczeWSZF+oHPdotzJDDldTrwwe0sUL3FtpdbYElWpYFkzgjOpuNai2TUlGh/ 8WZK8jIUTNzjG6ENkOz0p78g4iROZGnfUeo92kgkBah7bpQZG3qb6Uf+6n1C8Bm8Qyf5hGqH3of 3FL+e3qYLlxZz+WTgDf+ZCiMXVUNM+yjNOtXsW8YF57Ap0r0dqkHV4LnjttyrVLOO/+BxgnS/g/ D8nb2Tnj5OuDS6zIQm5GC/0= X-Google-Smtp-Source: AGHT+IG8mV9rv5yhc1iWlaV5S3t2ZOUGumy70/f6XFQ7FMoAQmt6hhsZbeWPJOdhiWP1nE1SaK4rgw== X-Received: by 2002:a17:902:ea11:b0:215:758c:52e8 with SMTP id d9443c01a7336-221045bc6demr11028735ad.12.1739567588330; Fri, 14 Feb 2025 13:13:08 -0800 (PST) Received: from localhost.localdomain ([2620:11a:c019:0:65e:3115:2f58:c5fd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d55908a7sm33285265ad.240.2025.02.14.13.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2025 13:13:07 -0800 (PST) From: Joe Damato To: netdev@vger.kernel.org Cc: stfomichev@gmail.com, horms@kernel.org, kuba@kernel.org, Joe Damato , Alexei Starovoitov , Andrew Lunn , bpf@vger.kernel.org (open list:XDP (eXpress Data Path):Keyword:(?:\b|_)xdp(?:\b|_)), Daniel Borkmann , Daniel Jurgens , "David S. Miller" , David Wei , Donald Hunter , Eric Dumazet , Jesper Dangaard Brouer , John Fastabend , linux-kernel@vger.kernel.org (open list), linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK), Martin Karsten , Mina Almasry , Paolo Abeni , Shuah Khan , Sridhar Samudrala , Stanislav Fomichev , Xuan Zhuo Subject: [PATCH net-next v8 0/3] netdev-genl: Add an xsk attribute to queues Date: Fri, 14 Feb 2025 21:12:28 +0000 Message-ID: <20250214211255.14194-1-jdamato@fastly.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Greetings: Welcome to v8. Minor change, see changelog below. Re-tested on my mlx5 system both with and without CONFIG_XDP_SOCKETS enabled and both with and without NETIF set. This is an attempt to followup on something Jakub asked me about [1], adding an xsk attribute to queues and more clearly documenting which queues are linked to NAPIs... After the RFC [2], Jakub suggested creating an empty nest for queues which have a pool, so I've adjusted this version to work that way. The nest can be extended in the future to express attributes about XSK as needed. Queues which are not used for AF_XDP do not have the xsk attribute present. I've run the included test on: - my mlx5 machine (via NETIF=) - without setting NETIF And the test seems to pass in both cases. Thanks, Joe [1]: https://lore.kernel.org/netdev/20250113143109.60afa59a@kernel.org/ [2]: https://lore.kernel.org/netdev/20250129172431.65773-1-jdamato@fastly.com/ v8: - Update the Makefile in patch 3 to use TEST_GEN_FILES instead of TEST_GET_PROGS. - Fix a codespell complaint in xdp_helper.c. v7: https://lore.kernel.org/netdev/20250213192336.42156-1-jdamato@fastly.com/ - Added CONFIG_XDP_SOCKETS to selftests/driver/net/config as suggested by Stanislav. - Updated xdp_helper.c to return -1 for AF_XDP non-existence, but 1 for other failures. - Updated queues.py to mark test as skipped if AF_XDP does not exist. v6: https://lore.kernel.org/bpf/20250210193903.16235-1-jdamato@fastly.com/ - Added ifdefs for CONFIG_XDP_SOCKETS in patch 2 as Stanislav suggested. v5: https://lore.kernel.org/bpf/20250208041248.111118-1-jdamato@fastly.com/ - Removed unused ret variable from patch 2 as Simon suggested. v4: https://lore.kernel.org/lkml/20250207030916.32751-1-jdamato@fastly.com/ - Add patch 1, as suggested by Jakub, which adds an empty nest helper. - Use the helper in patch 2, which makes the code cleaner and prevents a possible bug. v3: https://lore.kernel.org/netdev/20250204191108.161046-1-jdamato@fastly.com/ - Change comment format in patch 2 to avoid kdoc warnings. No other changes. v2: https://lore.kernel.org/all/20250203185828.19334-1-jdamato@fastly.com/ - Switched from RFC to actual submission now that net-next is open - Adjusted patch 1 to include an empty nest as suggested by Jakub - Adjusted patch 2 to update the test based on changes to patch 1, and to incorporate some Python feedback from Jakub :) rfc: https://lore.kernel.org/netdev/20250129172431.65773-1-jdamato@fastly.com/ Joe Damato (3): netlink: Add nla_put_empty_nest helper netdev-genl: Add an XSK attribute to queues selftests: drv-net: Test queue xsk attribute Documentation/netlink/specs/netdev.yaml | 13 ++- include/net/netlink.h | 15 +++ include/uapi/linux/netdev.h | 6 ++ net/core/netdev-genl.c | 12 +++ tools/include/uapi/linux/netdev.h | 6 ++ .../testing/selftests/drivers/net/.gitignore | 2 + tools/testing/selftests/drivers/net/Makefile | 3 + tools/testing/selftests/drivers/net/config | 1 + tools/testing/selftests/drivers/net/queues.py | 42 +++++++- .../selftests/drivers/net/xdp_helper.c | 98 +++++++++++++++++++ 10 files changed, 194 insertions(+), 4 deletions(-) create mode 100644 tools/testing/selftests/drivers/net/.gitignore create mode 100644 tools/testing/selftests/drivers/net/xdp_helper.c base-commit: 7a7e0197133d18cfd9931e7d3a842d0f5730223f