mbox series

[net-next,v3,0/7] net: deduplicate cookie logic

Message ID 20250214222720.3205500-1-willemdebruijn.kernel@gmail.com (mailing list archive)
Headers show
Series net: deduplicate cookie logic | expand

Message

Willem de Bruijn Feb. 14, 2025, 10:26 p.m. UTC
From: Willem de Bruijn <willemb@google.com>

Reuse standard sk, ip and ipv6 cookie init handlers where possible.

Avoid repeated open coding of the same logic.
Harmonize feature sets across protocols.
Make IPv4 and IPv6 logic more alike.
Simplify adding future new fields with a single init point.

v2->v3:
  - rebase, no code changes
  - commit messages: apply Reviewed-by from v2 (David Ahern)
  - commit messages: move changelog below --- (Paolo Abeni)
v1->v2:
  - limit INET_DSCP_MASK to routing
  - remove no longer used local variable (fix build warning)

Willem de Bruijn (7):
  tcp: only initialize sockcm tsflags field
  net: initialize mark in sockcm_init
  ipv4: initialize inet socket cookies with sockcm_init
  ipv4: remove get_rttos
  icmp: reflect tos through ip cookie rather than updating inet_sk
  ipv6: replace ipcm6_init calls with ipcm6_init_sk
  ipv6: initialize inet socket cookies with sockcm_init

 include/net/ip.h       | 16 +++++-----------
 include/net/ipv6.h     | 11 ++---------
 include/net/sock.h     |  1 +
 net/can/raw.c          |  2 +-
 net/ipv4/icmp.c        |  6 ++----
 net/ipv4/ping.c        |  6 +++---
 net/ipv4/raw.c         |  6 +++---
 net/ipv4/tcp.c         |  2 +-
 net/ipv4/udp.c         |  6 +++---
 net/ipv6/ping.c        |  3 ---
 net/ipv6/raw.c         | 15 +++------------
 net/ipv6/udp.c         | 10 +---------
 net/l2tp/l2tp_ip6.c    |  8 +-------
 net/packet/af_packet.c |  9 ++++-----
 14 files changed, 30 insertions(+), 71 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 19, 2025, 2:40 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 14 Feb 2025 17:26:57 -0500 you wrote:
> From: Willem de Bruijn <willemb@google.com>
> 
> Reuse standard sk, ip and ipv6 cookie init handlers where possible.
> 
> Avoid repeated open coding of the same logic.
> Harmonize feature sets across protocols.
> Make IPv4 and IPv6 logic more alike.
> Simplify adding future new fields with a single init point.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/7] tcp: only initialize sockcm tsflags field
    https://git.kernel.org/netdev/net-next/c/aaf6532d119d
  - [net-next,v3,2/7] net: initialize mark in sockcm_init
    https://git.kernel.org/netdev/net-next/c/6ad861519a69
  - [net-next,v3,3/7] ipv4: initialize inet socket cookies with sockcm_init
    https://git.kernel.org/netdev/net-next/c/94788792f379
  - [net-next,v3,4/7] ipv4: remove get_rttos
    https://git.kernel.org/netdev/net-next/c/9329b58395e5
  - [net-next,v3,5/7] icmp: reflect tos through ip cookie rather than updating inet_sk
    https://git.kernel.org/netdev/net-next/c/e8485911050a
  - [net-next,v3,6/7] ipv6: replace ipcm6_init calls with ipcm6_init_sk
    https://git.kernel.org/netdev/net-next/c/096208592b09
  - [net-next,v3,7/7] ipv6: initialize inet socket cookies with sockcm_init
    https://git.kernel.org/netdev/net-next/c/5cd2f78886dd

You are awesome, thank you!