| Message ID | 20250304-enic_cleanup_and_ext_cq-v2-0-85804263dad8@cisco.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | enic:enable 32, 64 byte cqes and get max rx/tx ring size from hw | expand |
On Tue, Mar 04, 2025 at 07:56:36PM -0500, Satish Kharat via B4 Relay wrote: > This series enables using the max rx and tx ring sizes read from hw. > For newer hw that can be up to 16k entries. This requires bigger > completion entries for rx queues. This series enables the use of the > 32 and 64 byte completion queues entries for enic rx queues on > supported hw versions. This is in addition to the exiting (default) > 16 byte rx cqes. > > Signed-off-by: Satish Kharat <satishkh@cisco.com> > --- > Changes in v2: > - Added net-next to the subject line. > - Removed inlines from function defs in .c file. > - Fixed function local variable style issues. > - Added couple of helper functions to common code. > - Fixed checkpatch errors and warnings. > - Link to v1: https://lore.kernel.org/r/20250227-enic_cleanup_and_ext_cq-v1-0-c314f95812bb@cisco.com > > --- > Satish Kharat (8): > enic: Move function from header file to c file > enic: enic rq code reorg > enic: enic rq extended cq defines > enic: enable rq extended cq support > enic : remove unused function cq_enet_wq_desc_dec > enic : added enic_wq.c and enic_wq.h > enic : cleanup of enic wq request completion path > enic : get max rq & wq entries supported by hw, 16K queues nit: please consistently use "enic: " as the subject prefix for the cover-letter and all patches in this patch-set.
On 3/6/25 3:56 PM, Simon Horman wrote: > On Tue, Mar 04, 2025 at 07:56:36PM -0500, Satish Kharat via B4 Relay wrote: >> This series enables using the max rx and tx ring sizes read from hw. >> For newer hw that can be up to 16k entries. This requires bigger >> completion entries for rx queues. This series enables the use of the >> 32 and 64 byte completion queues entries for enic rx queues on >> supported hw versions. This is in addition to the exiting (default) >> 16 byte rx cqes. >> >> Signed-off-by: Satish Kharat <satishkh@cisco.com> >> --- >> Changes in v2: >> - Added net-next to the subject line. >> - Removed inlines from function defs in .c file. >> - Fixed function local variable style issues. >> - Added couple of helper functions to common code. >> - Fixed checkpatch errors and warnings. >> - Link to v1: https://lore.kernel.org/r/20250227-enic_cleanup_and_ext_cq-v1-0-c314f95812bb@cisco.com >> >> --- >> Satish Kharat (8): >> enic: Move function from header file to c file >> enic: enic rq code reorg >> enic: enic rq extended cq defines >> enic: enable rq extended cq support >> enic : remove unused function cq_enet_wq_desc_dec >> enic : added enic_wq.c and enic_wq.h >> enic : cleanup of enic wq request completion path >> enic : get max rq & wq entries supported by hw, 16K queues > > nit: please consistently use "enic: " as the subject prefix for > the cover-letter and all patches in this patch-set. Since it looks otherwise good to me, I'll adjust the above while applying the patches. Thanks, Paolo
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Tue, 04 Mar 2025 19:56:36 -0500 you wrote: > This series enables using the max rx and tx ring sizes read from hw. > For newer hw that can be up to 16k entries. This requires bigger > completion entries for rx queues. This series enables the use of the > 32 and 64 byte completion queues entries for enic rx queues on > supported hw versions. This is in addition to the exiting (default) > 16 byte rx cqes. > > [...] Here is the summary with links: - [net-next,v2,1/8] enic: Move function from header file to c file https://git.kernel.org/netdev/net-next/c/025cf9318083 - [net-next,v2,2/8] enic: enic rq code reorg https://git.kernel.org/netdev/net-next/c/eaa23db8686f - [net-next,v2,3/8] enic: enic rq extended cq defines https://git.kernel.org/netdev/net-next/c/2be2eb764343 - [net-next,v2,4/8] enic: enable rq extended cq support https://git.kernel.org/netdev/net-next/c/bcb725c79cfa - [net-next,v2,5/8] enic : remove unused function cq_enet_wq_desc_dec https://git.kernel.org/netdev/net-next/c/6dca618c9467 - [net-next,v2,6/8] enic : added enic_wq.c and enic_wq.h https://git.kernel.org/netdev/net-next/c/e5f1bcd93d96 - [net-next,v2,7/8] enic : cleanup of enic wq request completion path https://git.kernel.org/netdev/net-next/c/26b2c5f6ff47 - [net-next,v2,8/8] enic : get max rq & wq entries supported by hw, 16K queues https://git.kernel.org/netdev/net-next/c/df9fd2a3ce01 You are awesome, thank you!
This series enables using the max rx and tx ring sizes read from hw. For newer hw that can be up to 16k entries. This requires bigger completion entries for rx queues. This series enables the use of the 32 and 64 byte completion queues entries for enic rx queues on supported hw versions. This is in addition to the exiting (default) 16 byte rx cqes. Signed-off-by: Satish Kharat <satishkh@cisco.com> --- Changes in v2: - Added net-next to the subject line. - Removed inlines from function defs in .c file. - Fixed function local variable style issues. - Added couple of helper functions to common code. - Fixed checkpatch errors and warnings. - Link to v1: https://lore.kernel.org/r/20250227-enic_cleanup_and_ext_cq-v1-0-c314f95812bb@cisco.com --- Satish Kharat (8): enic: Move function from header file to c file enic: enic rq code reorg enic: enic rq extended cq defines enic: enable rq extended cq support enic : remove unused function cq_enet_wq_desc_dec enic : added enic_wq.c and enic_wq.h enic : cleanup of enic wq request completion path enic : get max rq & wq entries supported by hw, 16K queues drivers/net/ethernet/cisco/enic/Makefile | 2 +- drivers/net/ethernet/cisco/enic/cq_desc.h | 25 +-- drivers/net/ethernet/cisco/enic/cq_enet_desc.h | 142 ++++++--------- drivers/net/ethernet/cisco/enic/enic.h | 13 ++ drivers/net/ethernet/cisco/enic/enic_ethtool.c | 12 +- drivers/net/ethernet/cisco/enic/enic_main.c | 69 ++----- drivers/net/ethernet/cisco/enic/enic_res.c | 87 +++++++-- drivers/net/ethernet/cisco/enic/enic_res.h | 11 +- drivers/net/ethernet/cisco/enic/enic_rq.c | 240 ++++++++++++++++++++++--- drivers/net/ethernet/cisco/enic/enic_rq.h | 6 +- drivers/net/ethernet/cisco/enic/enic_wq.c | 117 ++++++++++++ drivers/net/ethernet/cisco/enic/enic_wq.h | 7 + drivers/net/ethernet/cisco/enic/vnic_cq.h | 45 +---- drivers/net/ethernet/cisco/enic/vnic_devcmd.h | 19 ++ drivers/net/ethernet/cisco/enic/vnic_enet.h | 5 + drivers/net/ethernet/cisco/enic/vnic_rq.h | 2 +- drivers/net/ethernet/cisco/enic/vnic_wq.h | 2 +- 17 files changed, 545 insertions(+), 259 deletions(-) --- base-commit: de7a88b639d488607352a270ef2e052c4442b1b3 change-id: 20250218-enic_cleanup_and_ext_cq-f21868bbde07 Best regards,