mbox series

[net-next,0/2] net: bring back dev_addr_sem

Message ID 20250311084507.3978048-1-sdf@fomichev.me (mailing list archive)
Headers show
Series net: bring back dev_addr_sem | expand

Message

Stanislav Fomichev March 11, 2025, 8:45 a.m. UTC 
Kohei reports an issue with dev_addr_sem conversion to netdev instance
lock in [0]. Based on the discussion, switching to netdev instance
lock to protect the address might not work for the devices that
are not using netdev ops lock.
Bring dev_addr_sem instance lock back but fix the ordering.

0: https://lore.kernel.org/netdev/20250308203835.60633-2-enjuk@amazon.com

Stanislav Fomichev (2):
  Revert "net: replace dev_addr_sem with netdev instance lock"
  net: reorder dev_addr_sem lock

 drivers/net/tap.c         |  2 +-
 drivers/net/tun.c         |  2 +-
 include/linux/netdevice.h |  4 +++-
 net/core/dev.c            | 41 +++++++++++++--------------------------
 net/core/dev.h            |  3 ++-
 net/core/dev_api.c        | 19 ++++++++++++++++--
 net/core/dev_ioctl.c      |  2 +-
 net/core/net-sysfs.c      |  7 +++++--
 net/core/rtnetlink.c      | 17 +++++++++++-----
 9 files changed, 56 insertions(+), 41 deletions(-)

Comments

Lei Yang March 12, 2025, 1:25 p.m. UTC | #1 
QE tested this patch with virtio-net regression tests, everything works fine.

Tested-by: Lei Yang <leiyang@redhat.com>

On Tue, Mar 11, 2025 at 4:45 PM Stanislav Fomichev <sdf@fomichev.me> wrote:
>
> Kohei reports an issue with dev_addr_sem conversion to netdev instance
> lock in [0]. Based on the discussion, switching to netdev instance
> lock to protect the address might not work for the devices that
> are not using netdev ops lock.
> Bring dev_addr_sem instance lock back but fix the ordering.
>
> 0: https://lore.kernel.org/netdev/20250308203835.60633-2-enjuk@amazon.com
>
> Stanislav Fomichev (2):
>   Revert "net: replace dev_addr_sem with netdev instance lock"
>   net: reorder dev_addr_sem lock
>
>  drivers/net/tap.c         |  2 +-
>  drivers/net/tun.c         |  2 +-
>  include/linux/netdevice.h |  4 +++-
>  net/core/dev.c            | 41 +++++++++++++--------------------------
>  net/core/dev.h            |  3 ++-
>  net/core/dev_api.c        | 19 ++++++++++++++++--
>  net/core/dev_ioctl.c      |  2 +-
>  net/core/net-sysfs.c      |  7 +++++--
>  net/core/rtnetlink.c      | 17 +++++++++++-----
>  9 files changed, 56 insertions(+), 41 deletions(-)
>
> --
> 2.48.1
>
>