From patchwork Tue Mar 18 22:06:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Frieder Vogt via B4 Relay X-Patchwork-Id: 14021639 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B356C2066EC; Tue, 18 Mar 2025 22:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742335638; cv=none; b=uTk5ZjvIEWetEd/Jy9+/AEczQNTijDRfiHNDlpoUFcMA7gvDS9iUaTQl3LTHC2YY4xSwMyEcTBf3aT5BGWvBY2oWWy5o/vfjlR1VZcmqQo04i7P+UT5z0zJ8ME6QxZ6ad4ghMSmL7ndB1kaLlx2Qhy38eJK7LYTti3GVZFMRBX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742335638; c=relaxed/simple; bh=fuSRRLCgAuHKfgkb7sAtUwteFXpUie9s2v2hW3tLt7w=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=RwJxint1dj3Iv8WXKxh0RLdwMbh5QiejeR1BosvpJSHLFvXENZVx7M8NIijG1Ij3JWyhACZhPGKuoBYHdnt2DYyzw7NOBoOGxHlsKPVZptbwujZlQY09Ut11NpKcZAd+DfepfIDbRdZuJwmB0sg/1k4ofl0sIlDPwEra/MjO6i0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XCKNwzyn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XCKNwzyn" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0EE00C4CEDD; Tue, 18 Mar 2025 22:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742335638; bh=fuSRRLCgAuHKfgkb7sAtUwteFXpUie9s2v2hW3tLt7w=; h=From:Subject:Date:To:Cc:Reply-To:From; b=XCKNwzynzsCPNPcR8XmSOqy5CVI1WWVVBMGN9NtMUpHdu5Pj1UyqJkw/dhL2G2K+N z37NCozVZimajjoE5ZsAjMeD/krxL9yxjiMynDiFme0YkRKnQTzY62lygqEOKEnfil WpnIEM7guT0ipZu3BsQsqiW7fLq1xhltrJs2QIlozJPpKhoJnlSYoiLvOC9ndcz5fL W+tl36sSqlZm/yrFB6VUIlMFRZ3xtqrkieRmJqwRmI8EsrSR4sEqc1c0oi0MBK9Zj3 av6F9j9KAOceV9Qd7uFRgIyyltPv8UJ+fi4JD5HIUeoX2gwjF+mEdtPYALm553Y97l 4WVm0pXt16qMg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F21C35FF3; Tue, 18 Mar 2025 22:07:17 +0000 (UTC) From: Hans-Frieder Vogt via B4 Relay Subject: [PATCH net-next v6 0/7] net: tn40xx: add support for AQR105 based cards Date: Tue, 18 Mar 2025 23:06:51 +0100 Message-Id: <20250318-tn9510-v3a-v6-0-808a9089d24b@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAHvu2WcC/1XNTQ6CMBCG4auQrq3pP9SV9zAuCkyhC4ppSYMh3 N1CNMJyMnm+d0ERgoOIbsWCAiQX3ejzoS4FanrjO8CuzTdihAnKqMKT15ISnLjBrLENrWSrKmJ RBq8A1s372AN5mLCHeULP/KlNBFwH45t+GxuM8xvoXZzG8N7jie/s2ymPncQxwaKVYJVVlQJy7 4b5mgP7dhIHyOgJigxbY62tdG1KU56h/EFJGGMnKDPUmitJRAmc6D9c1/UD0rIKOzUBAAA= X-Change-ID: 20241216-tn9510-v3a-2cfc185d680f To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , FUJITA Tomonori , Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hans-Frieder Vogt X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742335636; l=4709; i=hfdevel@gmx.net; s=20240915; h=from:subject:message-id; bh=fuSRRLCgAuHKfgkb7sAtUwteFXpUie9s2v2hW3tLt7w=; b=m4k+HQ2xY+rjO5FT0aVg4u+UnpLTAxchkqtcWzSCb41gU4uIWDkegFhbLFQaQPapO9CiJ/2Dl LQrXSKRe/LYBFEhAU4ZueosDmcZGw2OTgluIvgMChTnoxzfb1jKhphI X-Developer-Key: i=hfdevel@gmx.net; a=ed25519; pk=s3DJ3DFe6BJDRAcnd7VGvvwPXcLgV8mrfbpt8B9coRc= X-Endpoint-Received: by B4 Relay for hfdevel@gmx.net/20240915 with auth_id=209 X-Original-From: Hans-Frieder Vogt Reply-To: hfdevel@gmx.net X-Patchwork-Delegate: kuba@kernel.org This patch series adds support to the Tehuti tn40xx driver for TN9510 cards which combine a TN4010 MAC with an Aquantia AQR105. It is an update of the patch series "net: tn40xx: add support for AQR105 based cards", addressing review comments and generally cleaning up the series. The patch was tested on a Tehuti TN9510 card (1fc9:4025:1fc9:3015). --- Changes in v6: - rebaseline to net-next - remove unneeded loop timing ability advertisment in aquantia_main.c (highlighted by Maxime Chevallier ) - add failure path in tn40_mdio.c if device_add_software_node fails (suggested by Ratheesh Kannoth ) - Link to v5: https://lore.kernel.org/r/20250222-tn9510-v3a-v5-0-99365047e309@gmx.net Changes in v5: - changed version because "b4 send --resend v4" did not succeed - used opportunity to rebaseline to net-next - only source code change is merging a split string in tn40_mdio.c, removing a warning from b4 prep --check - changed format of cover letter in line with b4 (sequence of changes from latest to oldest) - Link to v4: https://lore.kernel.org/r/20241221-tn9510-v3a-v4-0-dafff89ba7a7@gmx.net Changes in v4: - use separate aqr105 specific functions instead of adding aqr105 functionality in common functions, with need of "chip generation" parameter (suggested by Andrew Lunn ) - make generation and cleanup of swnodes more symmetric (suggested by Andrew Lunn ) - add MDIO/PHY software nodes only for devices that have an aqr105 PHY (suggested by FUJITA Tomonori ) - Link to v3: https://lore.kernel.org/r/20241217-tn9510-v3a-v3-0-4d5ef6f686e0@gmx.net Changes in v3: - aquantia_firmware: remove call to of_property_read_string. It should be called from the more generic function device_property_read_string - add more AQR105-specific function, to support proper advertising and auto- negotiation - re-organize the patches about the mdio speed and TN40_REG_MDIO_CMD_STAT, skipping the 1MHz intermediate speed step - re-organized the sequence of the patches: 1. changes to the general support functions (net/phy/mdio_bus.c) 2. changes to the aquantia PHY driver 3. changes to the tn40xx MAC driver, required to support the TN9510 cards - Link to v2: https://lore.kernel.org/netdev/trinity-602c050f-bc76-4557-9824-252b0de48659-1726429697171@3c-app-gmx-bap07/ Changes in v2: - simplify the check for a firmware-name in a swnode in the aquantia PHY driver (comment from Andrew Lunn) - changed the software node definition to an mdio node with phy child nodes, to be more in line with a typical device tree definition (also comment from Andrew Lunn) This also solves the problem with several TN4010-based cards that FUJITA Tomonori reported - clarified the cleanup calls, now calling fwnode_handle_put instead of software_node_unregister (comment by FUJITA Tomonori) - updated the function mdiobus_scan to support swnodes (following hint of Andrew Lunn) - remove the small patch to avoid failing after aqr_wait_reset_complete, now that a proper patch by Vladimir Oltean is available - replace setting of bit 3 in TN40_REG_MDIO_CMD_STAT by calling of tn40_mdio_set_speed (suggestion by FUJITA Tomonori) - cleaning up the distributed calls to set the MDIO speed in the tn40xx driver - define supported PCI-IDs including subvendor IDs to prevent loading on unsupported card - Link to v1: https://lore.kernel.org/netdev/trinity-33332a4a-1c44-46b7-8526-b53b1a94ffc2-1726082106356@3c-app-gmx-bs04/ --- Hans-Frieder Vogt (7): net: phy: Add swnode support to mdiobus_scan net: phy: aquantia: add probe function to aqr105 for firmware loading net: phy: aquantia: search for firmware-name in fwnode net: phy: aquantia: add essential functions to aqr105 driver net: tn40xx: create swnode for mdio and aqr105 phy and add to mdiobus net: tn40xx: prepare tn40xx driver to find phy of the TN9510 card net: tn40xx: add pci-id of the aqr105-based Tehuti TN4010 cards drivers/net/ethernet/tehuti/tn40.c | 9 +- drivers/net/ethernet/tehuti/tn40.h | 31 ++++ drivers/net/ethernet/tehuti/tn40_mdio.c | 84 +++++++++- drivers/net/phy/aquantia/aquantia_firmware.c | 7 +- drivers/net/phy/aquantia/aquantia_main.c | 240 ++++++++++++++++++++++++++- drivers/net/phy/mdio_bus.c | 14 ++ 6 files changed, 376 insertions(+), 9 deletions(-) --- base-commit: 23c9ff659140f97d44bf6fb59f89526a168f2b86 change-id: 20241216-tn9510-v3a-2cfc185d680f Best regards,