mbox series

[v2,net-next,00/15] AccECN protocol patch series

Message ID 20250318002710.29483-1-chia-yu.chang@nokia-bell-labs.com (mailing list archive)
Headers show
Series AccECN protocol patch series | expand

Message

Chia-Yu Chang (Nokia) March 18, 2025, 12:26 a.m. UTC 
From: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>

Hello,

Plese find v2:

v2 (18-03-2025)
- Add one missing patch from previous AccECN protocol preparation patch series to this patch series

The full patch series can be found in
https://github.com/L4STeam/linux-net-next/commits/upstream_l4steam/

The Accurate ECN draft can be found in
https://datatracker.ietf.org/doc/html/draft-ietf-tcpm-accurate-ecn-28

Best regards,
Chia-Yu

Chia-Yu Chang (1):
  tcp: accecn: AccECN option failure handling

Ilpo Järvinen (14):
  tcp: fast path functions later
  tcp: AccECN core
  tcp: accecn: AccECN negotiation
  tcp: accecn: add AccECN rx byte counters
  tcp: accecn: AccECN needs to know delivered bytes
  tcp: allow embedding leftover into option padding
  tcp: sack option handling improvements
  tcp: accecn: AccECN option
  tcp: accecn: AccECN option send control
  tcp: accecn: AccECN option ceb/cep heuristic
  tcp: accecn: AccECN ACE field multi-wrap heuristic
  tcp: accecn: try to fit AccECN option with SACK
  tcp: try to avoid safer when ACKs are thinned
  gro: flushing when CWR is set negatively affects AccECN

 include/linux/tcp.h        |  27 +-
 include/net/netns/ipv4.h   |   2 +
 include/net/tcp.h          | 198 +++++++++++--
 include/uapi/linux/tcp.h   |   7 +
 net/ipv4/syncookies.c      |   3 +
 net/ipv4/sysctl_net_ipv4.c |  19 ++
 net/ipv4/tcp.c             |  26 +-
 net/ipv4/tcp_input.c       | 591 +++++++++++++++++++++++++++++++++++--
 net/ipv4/tcp_ipv4.c        |   5 +-
 net/ipv4/tcp_minisocks.c   |  92 +++++-
 net/ipv4/tcp_offload.c     |   3 +-
 net/ipv4/tcp_output.c      | 299 +++++++++++++++++--
 net/ipv6/syncookies.c      |   1 +
 net/ipv6/tcp_ipv6.c        |   1 +
 14 files changed, 1177 insertions(+), 97 deletions(-)

Comments

Eric Dumazet March 18, 2025, 12:33 a.m. UTC | #1 
On Tue, Mar 18, 2025 at 1:27 AM <chia-yu.chang@nokia-bell-labs.com> wrote:
>
> From: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
>
> Hello,
>
> Plese find v2:
>
> v2 (18-03-2025)
> - Add one missing patch from previous AccECN protocol preparation patch series to this patch series
>
> The full patch series can be found in
> https://github.com/L4STeam/linux-net-next/commits/upstream_l4steam/
>
> The Accurate ECN draft can be found in
> https://datatracker.ietf.org/doc/html/draft-ietf-tcpm-accurate-ecn-28
>
> Best regards,
> Chia-Yu
>
> Chia-Yu Chang (1):
>   tcp: accecn: AccECN option failure handling


I do not see any tests, how can this be tested ?

I am extremely worried.
Chia-Yu Chang (Nokia) March 18, 2025, 10:28 a.m. UTC | #2 
Please see below.

> On Tue, Mar 18, 2025 at 1:27 AM <chia-yu.chang@nokia-bell-labs.com> wrote:
> >
> > From: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
> >
> > Hello,
> >
> > Plese find v2:
> >
> > v2 (18-03-2025)
> > - Add one missing patch from previous AccECN protocol preparation patch series to this patch series
> >
> > The full patch series can be found in
> > https://github.com/L4STeam/linux-net-next/commits/upstream_l4steam/
> >
> > The Accurate ECN draft can be found in
> > https://datatracker.ietf.org/doc/html/draft-ietf-tcpm-accurate-ecn-28
> >
> > Best regards,
> > Chia-Yu
> >
> > Chia-Yu Chang (1):
> >   tcp: accecn: AccECN option failure handling
>
>
> I do not see any tests, how can this be tested ?
>
> I am extremely worried.

Thanks for the feedback.

And I would do the packetdrill AccECN tests (https://github.com/minuscat/packetdrill_accecn/tree/main/gtests/net/tcp/accecn) to verify it.

I've tested the latest net-next (6.14-rc6 commit 702e3fa16cd42ba712825e8d6171ea4755bc0491) with all 41 AccECN patches (11 patches are in net-next and 30 patches will be submitted series-by-series).

All 189 cases are passed, does this look ok for you?