[v5,0/6] pds_fwctl: fwctl for AMD/Pensando core devices

Message

Nelson, Shannon March 20, 2025, 7:44 p.m. UTC

Following along from Jason's work [1] we have our initial patchset
for pds_fwctl - an auxiliary_bus driver for supporting fwctl through the
pds_core driver and its PDS core device.

The PDS core is PCI device that is separate and distinct from the
ionic Eth device and from the other PCI devices that can be supported
by the AMD/Pensando DSC.  It is used by pds_vdpa and pds_vfio_pci to
coordinate/communicate with the FW for setting up their services.

Until now the DSC's basic configurations for defining what devices to
support and for getting low-level device debug information have been
through internal commands not available from the host side, requiring
access into the DSC's own OS.  Adding the fwctl service allows us to start
bringing these capabilities up into the host, but they don't replace the
existing function-specific tools.  For example, these are things that make
the Eth PCI device appear on the PCI bus, while the tuning of the specific
Eth features still go through the standard ethtool/devlink/ip/etc tools.

The first two patches are a bit of clean up for pds_core's add and delete
of auxiliary_devices.  Those are followed by a patch to add the new
pds_core.fwctl auxiliary_device.  This is only supported by the pds_core
PF and not on any VFs.

The remaining patches add the pds_fwctl driver framework and then fill
in the details for the fwctl services.

[1] https://lore.kernel.org/netdev/[e-mail]/

v5:
  - fix missing variable declaration
  - fix kernel-doc complaint

v4: https://lore.kernel.org/netdev/[e-mail]/
  - fix commit description for better imperative (David)
  - fix comment wording (David)
  - add kdoc comment on struct fwctl_info_pds (David)
  - #include <linux/bitfield.h>  (Jason)
  - fix for error pointer check in pdsfc_validate_rpc() (Brett and Dan)
  - initialize pdsfc->caps
  - add translation of FW opcode scope to fwctl scope
  - several doc edits (David)
  - added received Reviewd-by tags

v3: https://lore.kernel.org/netdev/[e-mail]/
  - rebase on Jason's tree
  - better comment on "an error if there is no auxbus device support" (Jonathan)
  - don't call pdsc_auxbus_dev_del() if pdsc_auxbus_dev_add() failed (Jonathan)
  - struct pdsc *pdsc; is unnecessary in struct pdsfc_dev (Jonathan)
  - remove unused UID field in pdsfc_info (Jonathan, Jason)
  - change "Word boundary padding" to "Reserved" (Jonathan)
  - remove the remaining use of cleanup pattern
  - don't lose err from pds_client_adminq_cmd() in pdsfc_identify() (Jason)
  - comment on pds_fwctl_ident.features (Jonathan)
  - change noisy dev_errs to dev_dbg and remove a couple unnecessary ones (Jonathan, Jason)
  - no cast needed on struct fwctl_rpc_pds *rpc = (struct fwctl_rpc_pds *)in (Jonathan)
  - more labels and reverse order for cleanup in pdsfc_fw_rpc  (Jonathan)
  - __counted_by_le() on struct pds_fwctl_query_data (Jonathan)
  - other comment comments on new structs (Jonathan)
  - use FIELD_GET (Jason)
  - Use __aligned_u64 in the uapi headers (Jason)
  - call fwctl a subsystem in Docs (Jonathan)
  - clean up text around endpoints in Docs (Jonathan)

v2: https://lore.kernel.org/netdev/[e-mail]/
  - removed the RFC tag
  - add a patch to make pdsc_auxbus_dev_del() a void type (Jonathan)
  - fix up error handling if pdsc_auxbus_dev_add() fails in probe (Jonathan)
  - fix auxiliary spelling in commit subject header (Jonathan)
  - clean up of code around use of __free() gizmo (Jonathan, David)
  - removed extra whitespace and dev_xxx() calls (Leon)
  - copy ident info from DMA and release DMA memory in probe (Jonathan)
  - use dev_err_probe() (Jonathan)
  - add counted_by_le(num_entries) (Jonathan, David)
  - convert num_entries from __le32 to host in get_endpoints() (Jonathan)
  - remove unnecessary variable inits (Jonathan, Leon)

v1: https://lore.kernel.org/netdev/[e-mail]/

Brett Creeley (1):
  pds_fwctl: add rpc and query support

Shannon Nelson (5):
  pds_core: make pdsc_auxbus_dev_del() void
  pds_core: specify auxiliary_device to be created
  pds_core: add new fwctl auxiliary_device
  pds_fwctl: initial driver framework
  pds_fwctl: add Documentation entries

 Documentation/userspace-api/fwctl/fwctl.rst   |   1 +
 Documentation/userspace-api/fwctl/index.rst   |   1 +
 .../userspace-api/fwctl/pds_fwctl.rst         |  46 ++
 MAINTAINERS                                   |   7 +
 drivers/fwctl/Kconfig                         |  10 +
 drivers/fwctl/Makefile                        |   1 +
 drivers/fwctl/pds/Makefile                    |   4 +
 drivers/fwctl/pds/main.c                      | 539 ++++++++++++++++++
 drivers/net/ethernet/amd/pds_core/auxbus.c    |  44 +-
 drivers/net/ethernet/amd/pds_core/core.c      |   7 +
 drivers/net/ethernet/amd/pds_core/core.h      |   8 +-
 drivers/net/ethernet/amd/pds_core/devlink.c   |   7 +-
 drivers/net/ethernet/amd/pds_core/main.c      |  25 +-
 include/linux/pds/pds_adminq.h                | 277 +++++++++
 include/linux/pds/pds_common.h                |   2 +
 include/uapi/fwctl/fwctl.h                    |   1 +
 include/uapi/fwctl/pds.h                      |  62 ++
 17 files changed, 1008 insertions(+), 34 deletions(-)
 create mode 100644 Documentation/userspace-api/fwctl/pds_fwctl.rst
 create mode 100644 drivers/fwctl/pds/Makefile
 create mode 100644 drivers/fwctl/pds/main.c
 create mode 100644 include/uapi/fwctl/pds.h

Comments

Jason Gunthorpe March 20, 2025, 11:25 p.m. UTC | #1

On Thu, Mar 20, 2025 at 12:44:06PM -0700, Shannon Nelson wrote:
> Brett Creeley (1):
>   pds_fwctl: add rpc and query support
> 
> Shannon Nelson (5):
>   pds_core: make pdsc_auxbus_dev_del() void
>   pds_core: specify auxiliary_device to be created
>   pds_core: add new fwctl auxiliary_device
>   pds_fwctl: initial driver framework
>   pds_fwctl: add Documentation entries

Applied - though it has only been in linux-next for a few days, if
there are further problems or remarks we may need a v6

Thanks,
Jason