mbox series

[net,0/2] ipv6: Multipath routing fixes

Message ID 20250402114224.293392-1-idosch@nvidia.com (mailing list archive)
Headers show
Series ipv6: Multipath routing fixes | expand

Message

Ido Schimmel April 2, 2025, 11:42 a.m. UTC 
This patchset contains two fixes for IPv6 multipath routing. See the
commit messages for more details.

Ido Schimmel (2):
  ipv6: Start path selection from the first nexthop
  ipv6: Do not consider link down nexthops in path selection

 net/ipv6/route.c | 42 ++++++++++++++++++++++++++++++++++++++----
 1 file changed, 38 insertions(+), 4 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org April 4, 2025, 2:40 p.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 2 Apr 2025 14:42:22 +0300 you wrote:
> This patchset contains two fixes for IPv6 multipath routing. See the
> commit messages for more details.
> 
> Ido Schimmel (2):
>   ipv6: Start path selection from the first nexthop
>   ipv6: Do not consider link down nexthops in path selection
> 
> [...]

Here is the summary with links:
  - [net,1/2] ipv6: Start path selection from the first nexthop
    https://git.kernel.org/netdev/net/c/4d0ab3a6885e
  - [net,2/2] ipv6: Do not consider link down nexthops in path selection
    https://git.kernel.org/netdev/net/c/8b8e0dd35716

You are awesome, thank you!
Jakub Kicinski April 4, 2025, 2:49 p.m. UTC | #2 
On Fri, 04 Apr 2025 14:40:33 +0000 patchwork-bot+netdevbpf@kernel.org
wrote:
> Hello:
> 
> This series was applied to netdev/net.git (main)
> by Jakub Kicinski <kuba@kernel.org>:
> 
> On Wed, 2 Apr 2025 14:42:22 +0300 you wrote:
> > This patchset contains two fixes for IPv6 multipath routing. See the
> > commit messages for more details.
> > 
> > Ido Schimmel (2):
> >   ipv6: Start path selection from the first nexthop
> >   ipv6: Do not consider link down nexthops in path selection
> > 
> > [...]  
> 
> Here is the summary with links:
>   - [net,1/2] ipv6: Start path selection from the first nexthop
>     https://git.kernel.org/netdev/net/c/4d0ab3a6885e
>   - [net,2/2] ipv6: Do not consider link down nexthops in path selection
>     https://git.kernel.org/netdev/net/c/8b8e0dd35716
> 
> You are awesome, thank you!

Ugh, rushed this it seems.
Sorry, Willem.
Willem de Bruijn April 4, 2025, 4:22 p.m. UTC | #3 
Jakub Kicinski wrote:
> On Fri, 04 Apr 2025 14:40:33 +0000 patchwork-bot+netdevbpf@kernel.org
> wrote:
> > Hello:
> > 
> > This series was applied to netdev/net.git (main)
> > by Jakub Kicinski <kuba@kernel.org>:
> > 
> > On Wed, 2 Apr 2025 14:42:22 +0300 you wrote:
> > > This patchset contains two fixes for IPv6 multipath routing. See the
> > > commit messages for more details.
> > > 
> > > Ido Schimmel (2):
> > >   ipv6: Start path selection from the first nexthop
> > >   ipv6: Do not consider link down nexthops in path selection
> > > 
> > > [...]  
> > 
> > Here is the summary with links:
> >   - [net,1/2] ipv6: Start path selection from the first nexthop
> >     https://git.kernel.org/netdev/net/c/4d0ab3a6885e
> >   - [net,2/2] ipv6: Do not consider link down nexthops in path selection
> >     https://git.kernel.org/netdev/net/c/8b8e0dd35716
> > 
> > You are awesome, thank you!
> 
> Ugh, rushed this it seems.
> Sorry, Willem.

No worries of course.

I just did not see a more authoritative Reviewed-by and was trying to
better understand the code. I trust it's fine.
Guillaume Nault April 7, 2025, 3:12 p.m. UTC | #4 
On Wed, Apr 02, 2025 at 02:42:22PM +0300, Ido Schimmel wrote:
> This patchset contains two fixes for IPv6 multipath routing. See the
> commit messages for more details.

Thanks for fixing this Ido! I've sucessfully tested the patches
(although it's too late for a Tested-by tag).

> Ido Schimmel (2):
>   ipv6: Start path selection from the first nexthop
>   ipv6: Do not consider link down nexthops in path selection
> 
>  net/ipv6/route.c | 42 ++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 38 insertions(+), 4 deletions(-)
> 
> -- 
> 2.49.0
>