[net,v2,0/2] net: make memory provider install / close paths more common

Message

Jakub Kicinski April 3, 2025, 1:34 a.m. UTC

We seem to be fixing bugs in config path for devmem which also exist
in the io_uring ZC path. Let's try to make the two paths more common,
otherwise this is bound to keep happening.

Found by code inspection and compile tested only.

v2:
 - [patch 1] add to commit msg
 - [patch 1] fix arg naming in the header
 - [patch 2] don't split the registration check, it may cause a race
   if we just bail on the registration state and not on the MP being
   present, as we drop and re-take the instance lock after setting
   reg_state
v1: https://lore.kernel.org/[e-mail]

Jakub Kicinski (2):
  net: move mp dev config validation to __net_mp_open_rxq()
  net: avoid false positive warnings in __net_mp_close_rxq()

 include/net/page_pool/memory_provider.h |  6 +++
 net/core/devmem.c                       | 64 +++++++------------------
 net/core/netdev-genl.c                  |  6 ---
 net/core/netdev_rx_queue.c              | 53 +++++++++++++++-----
 4 files changed, 63 insertions(+), 66 deletions(-)

Comments

[e-mail] April 4, 2025, 3:10 p.m. UTC | #1

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[e-mail]>:

On Wed,  2 Apr 2025 18:34:03 -0700 you wrote:
> We seem to be fixing bugs in config path for devmem which also exist
> in the io_uring ZC path. Let's try to make the two paths more common,
> otherwise this is bound to keep happening.
> 
> Found by code inspection and compile tested only.
> 
> v2:
>  - [patch 1] add to commit msg
>  - [patch 1] fix arg naming in the header
>  - [patch 2] don't split the registration check, it may cause a race
>    if we just bail on the registration state and not on the MP being
>    present, as we drop and re-take the instance lock after setting
>    reg_state
> v1: https://lore.kernel.org/[e-mail]
> 
> [...]

Here is the summary with links:
  - [net,v2,1/2] net: move mp dev config validation to __net_mp_open_rxq()
    https://git.kernel.org/netdev/net/c/ec304b70d46b
  - [net,v2,2/2] net: avoid false positive warnings in __net_mp_close_rxq()
    https://git.kernel.org/netdev/net/c/34f71de3f548

You are awesome, thank you!