| Message ID | 3601E5DE87D2BC4F+20240604155850.51983-1-mengyuanlou@net-swift.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add sriov support for wangxun NICs | expand |
On Tue, 4 Jun 2024 23:57:29 +0800 Mengyuan Lou wrote: > Add sriov_configure for ngbe and txgbe drivers. > Reallocate queue and irq resources when sriov is enabled. > Add wx_msg_task in interrupts handler, which is used to process the > configuration sent by vfs. > Add ping_vf for wx_pf to tell vfs about pf link change. You have cut out the ndo_set_vf_* calls but you seem to add no uAPI access beyond just enabling the PCI SR-IOV capability. What's your plan of making this actually usable? It's a very strange submission.
> 2024年6月6日 08:42，Jakub Kicinski <kuba@kernel.org> 写道： > > On Tue, 4 Jun 2024 23:57:29 +0800 Mengyuan Lou wrote: >> Add sriov_configure for ngbe and txgbe drivers. >> Reallocate queue and irq resources when sriov is enabled. >> Add wx_msg_task in interrupts handler, which is used to process the >> configuration sent by vfs. >> Add ping_vf for wx_pf to tell vfs about pf link change. > > You have cut out the ndo_set_vf_* calls but you seem to add no uAPI > access beyond just enabling the PCI SR-IOV capability. What's your plan > of making this actually usable? It's a very strange submission. Vf driver(wxvf) will be submitted later, uAPI for virtual network devices will be added in it.
On Thu, 6 Jun 2024 18:13:07 +0800 mengyuanlou@net-swift.com wrote: > > You have cut out the ndo_set_vf_* calls but you seem to add no uAPI > > access beyond just enabling the PCI SR-IOV capability. What's your plan > > of making this actually usable? It's a very strange submission. > > Vf driver(wxvf) will be submitted later, uAPI for virtual network devices will > be added in it. I mean the configuration API equivalent to the legacy NDOs.
> 2024年6月6日 21:52，Jakub Kicinski <kuba@kernel.org> 写道： > > On Thu, 6 Jun 2024 18:13:07 +0800 mengyuanlou@net-swift.com wrote: >>> You have cut out the ndo_set_vf_* calls but you seem to add no uAPI >>> access beyond just enabling the PCI SR-IOV capability. What's your plan >>> of making this actually usable? It's a very strange submission. >> >> Vf driver(wxvf) will be submitted later, uAPI for virtual network devices will >> be added in it. > > I mean the configuration API equivalent to the legacy NDOs. > It starts here. - https://lore.kernel.org/netdev/20240403185300.702a8271@kernel.org/ > + .ndo_set_vf_spoofchk = wx_ndo_set_vf_spoofchk, > + .ndo_set_vf_link_state = wx_ndo_set_vf_link_state, > + .ndo_get_vf_config = wx_ndo_get_vf_config, > + .ndo_set_vf_vlan = wx_ndo_set_vf_vlan, > + .ndo_set_vf_mac = wx_ndo_set_vf_mac, Whether these interfaces are going to be deprecated, and I have no idea about what new apis can replace the ndo_{set|get}_vf_xxx interfaces. I have seen recently submitted driver(octeon_ep) which support sriov, do not add ndo_{set|get}_vf_xxx interfaces. - https://lore.kernel.org/netdev/20231215181425.2681426-1-srasheed@marvell.com/ If I have missed some docs or code?