mbox series

[net-next,0/2] r8169: improve RTL8168g PHY suspend quirk

Message ID 9303c2cf-c521-beea-c09f-63b5dfa91b9c@gmail.com (mailing list archive)
Headers show
Series r8169: improve RTL8168g PHY suspend quirk | expand

Message

Heiner Kallweit Jan. 6, 2021, 10:44 a.m. UTC 
According to Realtek the ERI register 0x1a8 quirk is needed to work
around a hw issue with the PHY on RTL8168g. The register needs to be
changed before powering down the PHY. Currently we don't meet this
requirement, however I'm not aware of any problems caused by this.
Therefore I see the change as an improvement.

The PHY driver has no means to access the chip ERI registers,
therefore we have to intercept MDIO writes to the BMCR register.
If the BMCR_PDOWN bit is going to be set, then let's apply the
quirk before actually powering down the PHY.

Heiner Kallweit (2):
  r8169: move ERI access functions to avoid forward declaration
  r8169: improve RTL8168g PHY suspend quirk

 drivers/net/ethernet/realtek/r8169_main.c | 180 +++++++++++-----------
 1 file changed, 90 insertions(+), 90 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 7, 2021, 11:10 p.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Wed, 6 Jan 2021 11:44:53 +0100 you wrote:
> According to Realtek the ERI register 0x1a8 quirk is needed to work
> around a hw issue with the PHY on RTL8168g. The register needs to be
> changed before powering down the PHY. Currently we don't meet this
> requirement, however I'm not aware of any problems caused by this.
> Therefore I see the change as an improvement.
> 
> The PHY driver has no means to access the chip ERI registers,
> therefore we have to intercept MDIO writes to the BMCR register.
> If the BMCR_PDOWN bit is going to be set, then let's apply the
> quirk before actually powering down the PHY.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] r8169: move ERI access functions to avoid forward declaration
    https://git.kernel.org/netdev/net-next/c/c6cff9dfebb3
  - [net-next,2/2] r8169: improve RTL8168g PHY suspend quirk
    https://git.kernel.org/netdev/net-next/c/acb58657c869

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html