| Message ID | DB3PR10MB6835598B901975BEAEBA8601E8DDA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests/bpf: Replaces CHECK macros and adds malloc failure checks to bpf_iter | expand |
On 10/25/23 19:03, Yuran Pereira wrote: > This patch series contains the following updates: > - Replaces the usage of all the CHECK macros in bpf_iter > to the appropriate ASSERT_* macro calls > - Adds appropriate malloc failure checks to bpf_iter > > Changes in v2: > - Removed unused "duration" variable which caused compilation error > as reported by Yonghong Song [1] > - Improved malloc failure handling as suggested by Kui-Feng Lee [2] > - Ensured propper patch formatting (i.e. sending it as a set instead > of two distinct patches) > > [1] https://lore.kernel.org/lkml/3531360b-c933-4c5f-a84c-17edf0592519@linux.dev/ > [2] https://lore.kernel.org/lkml/7d703c4c-1a24-4806-a483-c02efb666059@gmail.com > > > Previous version: > v1 - https://lore.kernel.org/lkml/DB3PR10MB683589A5F705C6CA5BE0D325E8DFA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM > - https://lore.kernel.org/lkml/DB3PR10MB68356D7CDF6005480BE5876CE8DEA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM > > Yuran Pereira (2): > selftests/bpf: Convert CHECK macros to ASSERT_* macros in bpf_iter > selftests/bpf: Add malloc failure checks in bpf_iter > > .../selftests/bpf/prog_tests/bpf_iter.c | 88 +++++++++---------- > 1 file changed, 44 insertions(+), 44 deletions(-) > For the cover letter, you can just put it at the same directory of patch 1 and 2 and sent them with "git send-email" at once. All of them will be in the same thread. "git format-patch --cover-letter ..." will generate a template of the cover letter along with patches. FYI
On Wed, Oct 25, 2023 at 09:37:44PM -0700, Kui-Feng Lee wrote: > > > On 10/25/23 19:03, Yuran Pereira wrote: > > This patch series contains the following updates: > > - Replaces the usage of all the CHECK macros in bpf_iter > > to the appropriate ASSERT_* macro calls > > - Adds appropriate malloc failure checks to bpf_iter > > > > Changes in v2: > > - Removed unused "duration" variable which caused compilation error > > as reported by Yonghong Song [1] > > - Improved malloc failure handling as suggested by Kui-Feng Lee [2] > > - Ensured propper patch formatting (i.e. sending it as a set instead > > of two distinct patches) > > > > [1] https://lore.kernel.org/lkml/3531360b-c933-4c5f-a84c-17edf0592519@linux.dev/ > > [2] https://lore.kernel.org/lkml/7d703c4c-1a24-4806-a483-c02efb666059@gmail.com > > > > > > Previous version: > > v1 - https://lore.kernel.org/lkml/DB3PR10MB683589A5F705C6CA5BE0D325E8DFA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM > > - https://lore.kernel.org/lkml/DB3PR10MB68356D7CDF6005480BE5876CE8DEA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM > > > > Yuran Pereira (2): > > selftests/bpf: Convert CHECK macros to ASSERT_* macros in bpf_iter > > selftests/bpf: Add malloc failure checks in bpf_iter > > > > .../selftests/bpf/prog_tests/bpf_iter.c | 88 +++++++++---------- > > 1 file changed, 44 insertions(+), 44 deletions(-) > > > > > For the cover letter, you can just put it at the same directory of > patch 1 and 2 and sent them with "git send-email" at once. All of them > will be in the same thread. > > "git format-patch --cover-letter ..." will generate a template > of the cover letter along with patches. FYI > Hello Kui-Feng, thanks for the feedback. So I did use "git format-patch --cover-letter", but for some reason "git send-email /path-to-patches/" seems to be deliberately sending the cover letter on a separate thread. IDK why. But "git send-email --compose" seems to be working as expected, so I'll use that and manually copy the cover letter generated by format-patch to ensure it's all on the same thread. Since I already butchered this thread, I will send v3 series on a separate thread. But I'll ensure to reference this thread on the cover letter. I'll be more careful with future patches.