mbox series

[RFC,net-next,0/7] net: dsa: cleanup EEE (part 2)

Message ID Z1hPaLFlR4TW_YCr@shell.armlinux.org.uk (mailing list archive)
Headers show
Series net: dsa: cleanup EEE (part 2) | expand

Message

Russell King (Oracle) Dec. 10, 2024, 2:25 p.m. UTC 
This is part 2 of the DSA EEE cleanups, and is being sent out becaues it
is relevant for the review of part 1, but would make part 1 too large.

Patch 1 removes the useless setting of tx_lpi parameters in the
ksz driver.

Patch 2 removes the DSA core code that calls the get_mac_eee() operation.
This needs to be done before removing the implementations because doing
otherwise would cause dsa_user_get_eee() to return -EOPNOTSUPP.

Patches 3..6 remove the trivial get_mac_eee() implementations from DSA
drivers.

Patch 7 finally removes the get_mac_eee() method from struct
dsa_switch_ops.

For part 2:

 drivers/net/dsa/b53/b53_common.c       |  7 -------
 drivers/net/dsa/b53/b53_priv.h         |  1 -
 drivers/net/dsa/bcm_sf2.c              |  1 -
 drivers/net/dsa/microchip/ksz_common.c | 15 ---------------
 drivers/net/dsa/mv88e6xxx/chip.c       |  8 --------
 drivers/net/dsa/qca/qca8k-8xxx.c       |  1 -
 drivers/net/dsa/qca/qca8k-common.c     |  7 -------
 drivers/net/dsa/qca/qca8k.h            |  1 -
 include/net/dsa.h                      |  2 --
 net/dsa/user.c                         | 12 ------------
 10 files changed, 55 deletions(-)

For part 1 and part 2 combined results in a net reduction of 33 LOC:

 drivers/net/dsa/b53/b53_common.c       | 14 ++++----------
 drivers/net/dsa/b53/b53_priv.h         |  2 +-
 drivers/net/dsa/bcm_sf2.c              |  2 +-
 drivers/net/dsa/microchip/ksz_common.c | 35 +++++-----------------------------
 drivers/net/dsa/mt7530.c               |  1 +
 drivers/net/dsa/mv88e6xxx/chip.c       |  9 +--------
 drivers/net/dsa/qca/qca8k-8xxx.c       |  2 +-
 drivers/net/dsa/qca/qca8k-common.c     |  7 -------
 drivers/net/dsa/qca/qca8k.h            |  1 -
 include/net/dsa.h                      |  4 ++--
 net/dsa/port.c                         | 16 ++++++++++++++++
 net/dsa/user.c                         | 18 +++++++----------
 12 files changed, 39 insertions(+), 72 deletions(-)

Comments

Vladimir Oltean Dec. 12, 2024, 7:48 p.m. UTC | #1 
On Tue, Dec 10, 2024 at 02:25:44PM +0000, Russell King (Oracle) wrote:
> This is part 2 of the DSA EEE cleanups, and is being sent out becaues it
> is relevant for the review of part 1, but would make part 1 too large.
> 
> Patch 1 removes the useless setting of tx_lpi parameters in the
> ksz driver.
> 
> Patch 2 removes the DSA core code that calls the get_mac_eee() operation.
> This needs to be done before removing the implementations because doing
> otherwise would cause dsa_user_get_eee() to return -EOPNOTSUPP.
> 
> Patches 3..6 remove the trivial get_mac_eee() implementations from DSA
> drivers.
> 
> Patch 7 finally removes the get_mac_eee() method from struct
> dsa_switch_ops.

I appreciate the splitting of the get_mac_eee() removal into multiple
patches per driver and 2 for the DSA framework. It should help BSP
backporters which target only a subset of DSA drivers. Monolithic
patches are harder to digest, and may have trivial context conflicts due
to unrelated changes.

The set looks good, please don't forget to also update the documentation.