[net-next,0/14] net: stmmac: yet more EEE updates

Message ID	Z6NqGnM2yL7Ayo-T@shell.armlinux.org.uk (mailing list archive)
Headers	show Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B77AB12EBEA for <netdev@vger.kernel.org>; Wed, 5 Feb 2025 13:39:49 +0000 (UTC) Date: Wed, 5 Feb 2025 13:39:38 +0000 From: "Russell King (Oracle)" <linux@armlinux.org.uk> To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>, Andrew Lunn <andrew+netdev@lunn.ch>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin <mcoquelin.stm32@gmail.com>, netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com> Subject: [PATCH net-next 0/14] net: stmmac: yet more EEE updates Message-ID: <Z6NqGnM2yL7Ayo-T@shell.armlinux.org.uk> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Series	net: stmmac: yet more EEE updates \| expand [net-next,0/14] net: stmmac: yet more EEE updates [net-next,01/14] net: stmmac: delete software timer before disabling LPI [net-next,02/14] net: stmmac: ensure LPI is disabled when disabling EEE [net-next,03/14] net: stmmac: dwmac4: ensure LPIATE is cleared [net-next,04/14] net: stmmac: split stmmac_init_eee() and move to phylink methods [net-next,05/14] net: stmmac: remove priv->dma_cap.eee test in tx_lpi methods [net-next,06/14] net: stmmac: remove unnecessary priv->eee_active tests [net-next,07/14] net: stmmac: remove unnecessary priv->eee_enabled tests [net-next,08/14] net: stmmac: clear priv->tx_path_in_lpi_mode when disabling LPI [net-next,09/14] net: stmmac: remove unnecessary LPI disable when enabling LPI [net-next,10/14] net: stmmac: use common LPI_CTRL_STATUS bit definitions [net-next,11/14] net: stmmac: add new MAC method set_lpi_mode() [net-next,12/14] net: stmmac: dwmac4: clear LPI_CTRL_STATUS_LPITCSE too [net-next,13/14] net: stmmac: use stmmac_set_lpi_mode() [net-next,14/14] net: stmmac: remove old EEE methods

Message ID

Z6NqGnM2yL7Ayo-T@shell.armlinux.org.uk (mailing list archive)

Headers

Date: Wed, 5 Feb 2025 13:39:38 +0000
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>, netdev@vger.kernel.org,
	Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH net-next 0/14] net: stmmac: yet more EEE updates
Message-ID: <Z6NqGnM2yL7Ayo-T@shell.armlinux.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

Series

net: stmmac: yet more EEE updates | expand

Message

Russell King (Oracle) Feb. 5, 2025, 1:39 p.m. UTC

Hi,

Continuing on with the STMMAC EEE cleanups from last cycle, this series
further cleans up the EEE code, and fixes a problem with the existing
implementation - disabling EEE doesn't immediately disable LPI
signalling until the next packet is transmitted. It likely also fixes
a potential race condition when trying to disable LPI vs the software
timer.

 drivers/net/ethernet/stmicro/stmmac/common.h       |  14 +++
 drivers/net/ethernet/stmicro/stmmac/dwmac1000.h    |  13 +-
 .../net/ethernet/stmicro/stmmac/dwmac1000_core.c   |  30 ++---
 drivers/net/ethernet/stmicro/stmmac/dwmac4.h       |  12 +-
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c  |  96 +++++++--------
 drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h     |   9 +-
 .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c    |  49 ++++----
 drivers/net/ethernet/stmicro/stmmac/hwif.h         |  21 ++--
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  | 133 ++++++++-------------
 9 files changed, 153 insertions(+), 224 deletions(-)