[net-next,0/4] Various mtk_eth_soc cleanups

Message

Russell King (Oracle) March 7, 2023, 4:19 p.m. UTC

Here are a number of patches that do a bit of cleanup to mtk_eth_soc.

The first patch cleans up mtk_gmac0_rgmii_adjust(), which is the
troublesome function preventing the driver becoming a post-March2020
phylink driver. It doesn't solve that problem, merely makes the code
easier to follow by getting rid of repeated tenary operators.

The second patch moves the check for DDR2 memory to the initialisation
of phylink's supported_interfaces - if TRGMII is not possible for some
reason, we should not be erroring out in phylink MAC operations when
that can be determined prior to phylink creation.

The third patch removes checks from mtk_mac_config() that are done
when initialising supported_interfaces - phylink will not call
mtk_mac_config() with an interface that was not marked as supported,
so these checks are redundant.

The last patch removes the remaining vestiges of REVMII and RMII
support, which appears to be entirely unused.

These shouldn't conflict with Daniel's patch set, but if they do I
will rework as appropriate.

Thanks.

 drivers/net/ethernet/mediatek/mtk_eth_soc.c | 81 ++++++++++++-----------------
 1 file changed, 33 insertions(+), 48 deletions(-)

Comments

[e-mail] March 9, 2023, 9:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <[e-mail]>:

On Tue, 7 Mar 2023 16:19:02 +0000 you wrote:
> Here are a number of patches that do a bit of cleanup to mtk_eth_soc.
> 
> The first patch cleans up mtk_gmac0_rgmii_adjust(), which is the
> troublesome function preventing the driver becoming a post-March2020
> phylink driver. It doesn't solve that problem, merely makes the code
> easier to follow by getting rid of repeated tenary operators.
> 
> [...]

Here is the summary with links:
  - [net-next,1/4] net: mtk_eth_soc: tidy mtk_gmac0_rgmii_adjust()
    https://git.kernel.org/netdev/net-next/c/04eb3d1cede0
  - [net-next,2/4] net: mtk_eth_soc: move trgmii ddr2 check to probe function
    https://git.kernel.org/netdev/net-next/c/7910898e1b2a
  - [net-next,3/4] net: mtk_eth_soc: remove unnecessary checks in mtk_mac_config()
    https://git.kernel.org/netdev/net-next/c/c9f9e3a3289f
  - [net-next,4/4] net: mtk_eth_soc: remove support for RMII and REVMII modes
    https://git.kernel.org/netdev/net-next/c/8cd9de08ccf6

You are awesome, thank you!