[net-next,0/2] Rework SFP A2 access conditionals

Message

Russell King (Oracle) March 9, 2023, 3:56 p.m. UTC

Hi,

This series reworks the SFP A2 (diagnostics and control) access so we
don't end up testing a variable number of conditions in several places.

This also resolves a minor issue where we may have a module indicating
that it is not SFF8472 compliant, doesn't implement A2, but fails to
set the enhanced option byte to zero, leading to accesses to the A2
page that fail.

The first patch adds a new flag "have_a2" which indicates whether we
should be accessing the A2 page, and uses this for hwmon. The
conditions are kept the same.

The second patch extends the check for soft-state polling and control
by using this "have_a2" flag (which effectively augments the check to
include some level of SFF8472 compliance.)

 drivers/net/phy/sfp.c | 48 +++++++++++++++++++++++++++++-------------------
 1 file changed, 29 insertions(+), 19 deletions(-)

Comments

[e-mail] March 11, 2023, 2:20 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Thu, 9 Mar 2023 15:56:14 +0000 you wrote:
> Hi,
> 
> This series reworks the SFP A2 (diagnostics and control) access so we
> don't end up testing a variable number of conditions in several places.
> 
> This also resolves a minor issue where we may have a module indicating
> that it is not SFF8472 compliant, doesn't implement A2, but fails to
> set the enhanced option byte to zero, leading to accesses to the A2
> page that fail.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: sfp: add A2h presence flag
    https://git.kernel.org/netdev/net-next/c/f94b9bed12e8
  - [net-next,2/2] net: sfp: only use soft polling if we have A2h access
    https://git.kernel.org/netdev/net-next/c/5daed426f012

You are awesome, thank you!