mbox series

[net-next,0/2] Minor fixes for pcs_get_state() implementations

Message ID ZBHaQDM+G/o/UW3i@shell.armlinux.org.uk (mailing list archive)
Headers show
Series Minor fixes for pcs_get_state() implementations | expand

Message

Russell King (Oracle) March 15, 2023, 2:46 p.m. UTC 
Hi,

This series contains a number fixes for minor issues with some
pcs_get_state() implementations, particualrly for the phylink
state->an_enabled member. As they are minor, I'm suggesting we
queue them in net-next as there is follow-on work for these, and
there is no urgency for them to be in -rc.

Just like phylib, state->advertising's Autoneg bit is a copy of
state->an_enabled, and thus it is my intention to remove
state->an_enabled from phylink to simplify things.

This series gets rid of state->an_enabled assignments or
reporting that should never have been there.

 drivers/net/pcs/pcs-lynx.c |  4 ++--
 drivers/net/pcs/pcs-xpcs.c | 13 ++-----------
 2 files changed, 4 insertions(+), 13 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 17, 2023, 8:30 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Wed, 15 Mar 2023 14:46:24 +0000 you wrote:
> Hi,
> 
> This series contains a number fixes for minor issues with some
> pcs_get_state() implementations, particualrly for the phylink
> state->an_enabled member. As they are minor, I'm suggesting we
> queue them in net-next as there is follow-on work for these, and
> there is no urgency for them to be in -rc.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: pcs: xpcs: remove double-read of link state when using AN
    https://git.kernel.org/netdev/net-next/c/ef63461caf42
  - [net-next,2/2] net: pcs: lynx: don't print an_enabled in pcs_get_state()
    https://git.kernel.org/netdev/net-next/c/ecec0ebbc638

You are awesome, thank you!