[0/2] macvlan: Allow some packets to bypass broadcast queue

Message

Herbert Xu March 28, 2023, 2:56 a.m. UTC

This patch series allows some packets to bypass the broadcast
queue on receive.  Currently all multicast packets are queued
on receive and then processed in a work queue.  This is to avoid
an unbounded amount of work occurring in the receive path, as
one broadcast packet could easily translate into 4,000 packets.

However, for multicast packets with just one receiver (possible
for IPv6 ND), this introduces unnecessary latency as the packet
will go to exactly one device.

This series allows such multicast packets to be processed inline.
It also adds a toggle which lets the admin control what threshold
to set between queueing and not queueing.  A follow-up patch for
iproute will be posted.

Cheers,

Comments

[e-mail] March 29, 2023, 8:10 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <[e-mail]>:

On Tue, 28 Mar 2023 10:56:57 +0800 you wrote:
> This patch series allows some packets to bypass the broadcast
> queue on receive.  Currently all multicast packets are queued
> on receive and then processed in a work queue.  This is to avoid
> an unbounded amount of work occurring in the receive path, as
> one broadcast packet could easily translate into 4,000 packets.
> 
> However, for multicast packets with just one receiver (possible
> for IPv6 ND), this introduces unnecessary latency as the packet
> will go to exactly one device.
> 
> [...]

Here is the summary with links:
  - [1/2] macvlan: Skip broadcast queue if multicast with single receiver
    https://git.kernel.org/netdev/net-next/c/d45276e75e90
  - [2/2] macvlan: Add netlink attribute for broadcast cutoff
    https://git.kernel.org/netdev/net-next/c/954d1fa1ac93

You are awesome, thank you!